third_party/WebKit/Source/core/layout/line/InlineBox.h - Issue 2124793002: Use the correct bounding rect in SVGInlineTextBox::nodeAtPoint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineBox.h

Issue 2124793002: Use the correct bounding rect in SVGInlineTextBox::nodeAtPoint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/hittest/text-vertical.html ('k') | third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp » ('j') | third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/line/InlineBox.h

diff --git a/third_party/WebKit/Source/core/layout/line/InlineBox.h b/third_party/WebKit/Source/core/layout/line/InlineBox.h

index 40d75eb10c8285bd1c2b218b66830a5e6661d4b4..88648e9a09d37cfe4e6381e9b64862da8738b007 100644

--- a/third_party/WebKit/Source/core/layout/line/InlineBox.h

+++ b/third_party/WebKit/Source/core/layout/line/InlineBox.h

@@ -234,6 +234,7 @@ public:

// The logical height is our extent in the block flow direction, i.e., height for horizontal text and width for vertical text.

LayoutUnit logicalHeight() const;

+ LayoutSize logicalSize() const { return LayoutSize(m_logicalWidth, logicalHeight()); }

Stephen Chennney 2016/07/06 14:47:37 I don't think it's worth adding this to InlineBox.

LayoutRect logicalFrameRect() const { return isHorizontal() ? LayoutRect(m_topLeft.x(), m_topLeft.y(), m_logicalWidth, logicalHeight()) : LayoutRect(m_topLeft.y(), m_topLeft.x(), m_logicalWidth, logicalHeight()); }

virtual int baselinePosition(FontBaseline baselineType) const;