Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/layout/line/InlineBox.h

Issue 2124793002: Use the correct bounding rect in SVGInlineTextBox::nodeAtPoint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All r ights reserved. 2 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All r ights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 setX(top); 227 setX(top);
228 } 228 }
229 229
230 // The logical width is our extent in the line's overall inline direction, i .e., width for horizontal text and height for vertical text. 230 // The logical width is our extent in the line's overall inline direction, i .e., width for horizontal text and height for vertical text.
231 void setLogicalWidth(LayoutUnit w) { m_logicalWidth = w; } 231 void setLogicalWidth(LayoutUnit w) { m_logicalWidth = w; }
232 LayoutUnit logicalWidth() const { return m_logicalWidth; } 232 LayoutUnit logicalWidth() const { return m_logicalWidth; }
233 233
234 // The logical height is our extent in the block flow direction, i.e., heigh t for horizontal text and width for vertical text. 234 // The logical height is our extent in the block flow direction, i.e., heigh t for horizontal text and width for vertical text.
235 LayoutUnit logicalHeight() const; 235 LayoutUnit logicalHeight() const;
236 236
237 LayoutSize logicalSize() const { return LayoutSize(m_logicalWidth, logicalHe ight()); }
Stephen Chennney 2016/07/06 14:47:37 I don't think it's worth adding this to InlineBox.
237 LayoutRect logicalFrameRect() const { return isHorizontal() ? LayoutRect(m_t opLeft.x(), m_topLeft.y(), m_logicalWidth, logicalHeight()) : LayoutRect(m_topLe ft.y(), m_topLeft.x(), m_logicalWidth, logicalHeight()); } 238 LayoutRect logicalFrameRect() const { return isHorizontal() ? LayoutRect(m_t opLeft.x(), m_topLeft.y(), m_logicalWidth, logicalHeight()) : LayoutRect(m_topLe ft.y(), m_topLeft.x(), m_logicalWidth, logicalHeight()); }
238 239
239 virtual int baselinePosition(FontBaseline baselineType) const; 240 virtual int baselinePosition(FontBaseline baselineType) const;
240 virtual LayoutUnit lineHeight() const; 241 virtual LayoutUnit lineHeight() const;
241 242
242 virtual int caretMinOffset() const; 243 virtual int caretMinOffset() const;
243 virtual int caretMaxOffset() const; 244 virtual int caretMaxOffset() const;
244 245
245 unsigned char bidiLevel() const { return m_bitfields.bidiEmbeddingLevel(); } 246 unsigned char bidiLevel() const { return m_bitfields.bidiEmbeddingLevel(); }
246 void setBidiLevel(unsigned char level) { m_bitfields.setBidiEmbeddingLevel(l evel); } 247 void setBidiLevel(unsigned char level) { m_bitfields.setBidiEmbeddingLevel(l evel); }
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
455 456
456 } // namespace blink 457 } // namespace blink
457 458
458 #ifndef NDEBUG 459 #ifndef NDEBUG
459 // Outside the WebCore namespace for ease of invocation from gdb. 460 // Outside the WebCore namespace for ease of invocation from gdb.
460 void showTree(const blink::InlineBox*); 461 void showTree(const blink::InlineBox*);
461 void showLineTree(const blink::InlineBox*); 462 void showLineTree(const blink::InlineBox*);
462 #endif 463 #endif
463 464
464 #endif // InlineBox_h 465 #endif // InlineBox_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698