Use the correct bounding rect in SVGInlineTextBox::nodeAtPoint

Use the correct bounding rect in SVGInlineTextBox::nodeAtPoint

When writing-mode was unprefixed, SVGInlineTextBoxes started getting the
same treatment as their base-class, and hence we need to be careful when
we consider sizes for the inline boxes.
Use logicalWidth() and logicalHeight() instead of size().

BUG=587455
Committed: https://crrev.com/ccf72ce87493b653f3f1add48b2bd0a68108d35b
Cr-Commit-Position: refs/heads/master@{#403913}

[fs, 2016-07-05 14:09:00]

fs@opera.com changed reviewers:
+ pdr@chromium.org, schenney@chromium.org

[Stephen Chennney, 2016-07-06 14:47:37]

I presume the test fails without the change.

My code comment is driven by a desire to not add yet more weight to InlineBox.h.

https://codereview.chromium.org/2124793002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/line/InlineBox.h (right):

https://codereview.chromium.org/2124793002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/line/InlineBox.h:237: LayoutSize
logicalSize() const { return LayoutSize(m_logicalWidth, logicalHeight()); }
I don't think it's worth adding this to InlineBox.h when it's only used once in
SVG code.

https://codereview.chromium.org/2124793002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp
(right):

https://codereview.chromium.org/2124793002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp:247:
LayoutRect rect(topLeft(), logicalSize());
You can do "LayoutRect rect(topLeft(), LayoutSize(logicalWidth(),
logicalheight()));", right?

[fs, 2016-07-06 15:00:29]

Description was changed from

==========
Use the correct bounding rect in SVGInlineTextBox::nodeAtPoint

When writing-mode was unprefixed, SVGInlineTextBoxes started getting the
same treatment as their base-class, and hence we need to be careful when
we consider sizes for the inline boxes.
Add a new method InlineBox::logicalSize() and use that instead of
size().

BUG=587455
==========

to

==========
Use the correct bounding rect in SVGInlineTextBox::nodeAtPoint

When writing-mode was unprefixed, SVGInlineTextBoxes started getting the
same treatment as their base-class, and hence we need to be careful when
we consider sizes for the inline boxes.
Use logicalWidth() and logicalHeight() instead of size().

BUG=587455
==========

[fs, 2016-07-06 15:00:51]

https://codereview.chromium.org/2124793002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp
(right):

https://codereview.chromium.org/2124793002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp:247:
LayoutRect rect(topLeft(), logicalSize());
On 2016/07/06 at 14:47:37, Stephen Chennney wrote:
> You can do "LayoutRect rect(topLeft(), LayoutSize(logicalWidth(),
logicalheight()));", right?

Yes. Done, and dropped method.

[Stephen Chennney, 2016-07-06 15:45:31]

lgtm

[fs, 2016-07-06 15:47:20]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-07-06 15:47:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 16:21:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-06 16:22:07]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-06 16:24:07]

Description was changed from

==========
Use the correct bounding rect in SVGInlineTextBox::nodeAtPoint

When writing-mode was unprefixed, SVGInlineTextBoxes started getting the
same treatment as their base-class, and hence we need to be careful when
we consider sizes for the inline boxes.
Use logicalWidth() and logicalHeight() instead of size().

BUG=587455
==========

to

==========
Use the correct bounding rect in SVGInlineTextBox::nodeAtPoint

When writing-mode was unprefixed, SVGInlineTextBoxes started getting the
same treatment as their base-class, and hence we need to be careful when
we consider sizes for the inline boxes.
Use logicalWidth() and logicalHeight() instead of size().

BUG=587455

Committed: https://crrev.com/ccf72ce87493b653f3f1add48b2bd0a68108d35b
Cr-Commit-Position: refs/heads/master@{#403913}
==========

[commit-bot: I haz the power, 2016-07-06 16:24:09]

Patchset 2 (id:??) landed as
https://crrev.com/ccf72ce87493b653f3f1add48b2bd0a68108d35b
Cr-Commit-Position: refs/heads/master@{#403913}