Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3096)

Unified Diff: chrome/browser/permissions/permission_bubble_request_impl.cc

Issue 2124703002: Record metrics for permission prompt acceptance vs. user gesture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add histograms Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_bubble_request_impl.cc
diff --git a/chrome/browser/permissions/permission_bubble_request_impl.cc b/chrome/browser/permissions/permission_bubble_request_impl.cc
index 20017753f8c837f8a765390fe0888fbc495a50ee..dc66d938ed254ec15ee14ff8110112f19c77eacc 100644
--- a/chrome/browser/permissions/permission_bubble_request_impl.cc
+++ b/chrome/browser/permissions/permission_bubble_request_impl.cc
@@ -17,6 +17,7 @@
PermissionBubbleRequestImpl::PermissionBubbleRequestImpl(
const GURL& request_origin,
content::PermissionType permission_type,
+ bool has_gesture,
const PermissionDecidedCallback& permission_decided_callback,
const base::Closure delete_callback)
: request_origin_(request_origin),
@@ -154,3 +155,9 @@ PermissionBubbleType PermissionBubbleRequestImpl::GetPermissionBubbleType()
return PermissionBubbleType::UNKNOWN;
}
}
+
+PermissionBubbleGestureType PermissionBubbleRequestImpl::GetGestureType()
+ const {
+ return has_gesture_ ? PermissionBubbleGestureType::GESTURE
+ : PermissionBubbleGestureType::NO_GESTURE;
+}
« no previous file with comments | « chrome/browser/permissions/permission_bubble_request_impl.h ('k') | chrome/browser/permissions/permission_context_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698