Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2500)

Unified Diff: chrome/browser/permissions/permission_bubble_request_impl.h

Issue 2124703002: Record metrics for permission prompt acceptance vs. user gesture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add histograms Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_bubble_request_impl.h
diff --git a/chrome/browser/permissions/permission_bubble_request_impl.h b/chrome/browser/permissions/permission_bubble_request_impl.h
index 7eb40659bea282be3c102b8c9cf78cfbbdf07eba..f7021eb9d8ffc6c44b2bcf97a28d1d7310ca4cbf 100644
--- a/chrome/browser/permissions/permission_bubble_request_impl.h
+++ b/chrome/browser/permissions/permission_bubble_request_impl.h
@@ -25,6 +25,7 @@ class PermissionBubbleRequestImpl : public PermissionBubbleRequest {
PermissionBubbleRequestImpl(
const GURL& request_origin,
content::PermissionType permission_type,
+ bool has_gesture,
const PermissionDecidedCallback& permission_decided_callback,
const base::Closure delete_callback);
@@ -46,9 +47,11 @@ class PermissionBubbleRequestImpl : public PermissionBubbleRequest {
void Cancelled() override;
void RequestFinished() override;
PermissionBubbleType GetPermissionBubbleType() const override;
+ PermissionBubbleGestureType GetGestureType() const override;
GURL request_origin_;
content::PermissionType permission_type_;
+ bool has_gesture_;
// Called once a decision is made about the permission.
const PermissionDecidedCallback permission_decided_callback_;

Powered by Google App Engine
This is Rietveld 408576698