third_party/WebKit/Source/core/workers/WorkerThread.h - Issue 2124693002: Worker: Fix broken GC logic on Dedicated Worker while DOMTimer is set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThread.h

Issue 2124693002: Worker: Fix broken GC logic on Dedicated Worker while DOMTimer is set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: annotate WorkerGlobalScope interface with 'ActiveScriptWrappable' and make tests stricter Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp ('K') | « third_party/WebKit/Source/core/workers/WorkerGlobalScope.idl ('k') | third_party/WebKit/Source/core/workers/WorkerThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkerThread.h

diff --git a/third_party/WebKit/Source/core/workers/WorkerThread.h b/third_party/WebKit/Source/core/workers/WorkerThread.h

index 834fda0c02a1151fde140019074fae7add1ffb73..a0c308b078007622ba070e868594a613d7cfc137 100644

--- a/third_party/WebKit/Source/core/workers/WorkerThread.h

+++ b/third_party/WebKit/Source/core/workers/WorkerThread.h

@@ -170,9 +170,6 @@ protected:

// out of this class.

virtual bool isOwningBackingThread() const { return true; }

- // Called on the worker thread.

- virtual void postInitialize() { }

private:

friend class WorkerThreadTest;

FRIEND_TEST_ALL_PREFIXES(WorkerThreadTest, StartAndTerminateOnInitialization_TerminateWhileDebuggerTaskIsRunning);