third_party/WebKit/Source/core/workers/WorkerThread.cpp - Issue 2124693002: Worker: Fix broken GC logic on Dedicated Worker while DOMTimer is set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThread.cpp

Issue 2124693002: Worker: Fix broken GC logic on Dedicated Worker while DOMTimer is set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: annotate WorkerGlobalScope interface with 'ActiveScriptWrappable' and make tests stricter Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp ('K') | « third_party/WebKit/Source/core/workers/WorkerThread.h ('k') | third_party/WebKit/Source/platform/scheduler/child/compositor_worker_scheduler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkerThread.cpp

diff --git a/third_party/WebKit/Source/core/workers/WorkerThread.cpp b/third_party/WebKit/Source/core/workers/WorkerThread.cpp

index 8b7022d3a76fc3ebc41a1b27fa30e761d8ca852d..06bdad223180af056f45eb5cb0df6e69fa725041 100644

--- a/third_party/WebKit/Source/core/workers/WorkerThread.cpp

+++ b/third_party/WebKit/Source/core/workers/WorkerThread.cpp

@@ -28,8 +28,6 @@

#include "bindings/core/v8/Microtask.h"

#include "bindings/core/v8/ScriptSourceCode.h"

-#include "bindings/core/v8/V8GCController.h"

-#include "bindings/core/v8/V8IdleTaskRunner.h"

#include "bindings/core/v8/WorkerOrWorkletScriptController.h"

#include "core/inspector/ConsoleMessageStorage.h"

#include "core/inspector/InspectorInstrumentation.h"

@@ -541,8 +539,6 @@ void WorkerThread::initializeOnWorkerThread(std::unique_ptr<WorkerThreadStartupD

workerGlobalScope->didEvaluateWorkerScript();

m_workerReportingProxy.didEvaluateWorkerScript(success);

}

- postInitialize();

}

void WorkerThread::prepareForShutdownOnWorkerThread()