chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h - Issue 2124513002: Introduce ManifestUpgradeDetector for WebAPK to detect web manifest changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h

Issue 2124513002: Introduce ManifestUpgradeDetector for WebAPK to detect web manifest changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Introduce manifest upgrade detector. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java ('K') | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc ('k') | chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc » ('j') | chrome/browser/android/webapps/manifest_upgrade_detector.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h

diff --git a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h b/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h

index 3effb7b6b9a29f0c73c04b811a9d1e83ff2a7b0f..73bf033ab8d87149925a73c76bd3e6619f4d6127 100644

--- a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h

+++ b/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h

@@ -46,10 +46,13 @@ class AddToHomescreenDialogHelper :

// AddToHomescreenDataFetcher::Observer

void OnUserTitleAvailable(const base::string16& user_title) override;

- void OnDataAvailable(const ShortcutInfo& info, const SkBitmap& icon) override;

+ void OnDataAvailable(const ShortcutInfo& info,

+ const SkBitmap& icon,

+ const std::vector<std::string>& icon_urls) override;

SkBitmap FinalizeLauncherIcon(const SkBitmap& icon,

const GURL& url,

bool* is_generated) override;

+ void OnDidHasManifest(bool has_manifest) override {}

private:

virtual ~AddToHomescreenDialogHelper();