Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc

Issue 2124513002: Introduce ManifestUpgradeDetector for WebAPK to detect web manifest changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Introduce manifest upgrade detector. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc
diff --git a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc b/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc
index bc55cb26db57533d4050e4ae37e0a09bc64cecdf..ef589572be68e904253cebc6256541491285cbd6 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc
+++ b/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc
@@ -44,7 +44,7 @@ AddToHomescreenDialogHelper::AddToHomescreenDialogHelper(
ShortcutHelper::GetMinimumHomescreenIconSizeInDp(),
ShortcutHelper::GetIdealSplashImageSizeInDp(),
ShortcutHelper::GetMinimumSplashImageSizeInDp(),
- this)) {
+ false, this)) {
java_ref_.Reset(env, obj);
}
@@ -63,8 +63,10 @@ void AddToHomescreenDialogHelper::OnUserTitleAvailable(
j_user_title.obj());
}
-void AddToHomescreenDialogHelper::OnDataAvailable(const ShortcutInfo& info,
- const SkBitmap& icon) {
+void AddToHomescreenDialogHelper::OnDataAvailable(
+ const ShortcutInfo& info,
+ const SkBitmap& icon,
+ const std::vector<std::string>& icon_urls) {
JNIEnv* env = base::android::AttachCurrentThread();
ScopedJavaLocalRef<jobject> java_bitmap;
if (icon.getSize())

Powered by Google App Engine
This is Rietveld 408576698