Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2124453002: Unit test: confirm the image is updated after ImageResource::reloadIfLoFi() (Closed)

Created:
4 years, 5 months ago by hiroshige
Modified:
4 years, 5 months ago
Reviewers:
megjablon
CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unit test: confirm the image is updated after ImageResource::reloadIfLoFi() BUG=620203

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1

Patch Set 3 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp View 1 2 1 chunk +8 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 2114213002 Patch 20001

Messages

Total messages: 12 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124453002/1
4 years, 5 months ago (2016-07-04 11:41:41 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124453002/20001
4 years, 5 months ago (2016-07-04 12:00:06 UTC) #5
hiroshige
https://codereview.chromium.org/2124453002/diff/20001/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp File third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp (right): https://codereview.chromium.org/2124453002/diff/20001/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp#newcode363 third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp:363: ASSERT_FALSE(cachedImage->hasImage()); https://chromiumcodereview.appspot.com/1928823002/ turned this line from ASSERT_FALSE to ASSERT_TRUE, ...
4 years, 5 months ago (2016-07-04 12:34:55 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124453002/40001
4 years, 5 months ago (2016-07-04 12:37:06 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 13:48:27 UTC) #12 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698