Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Unified Diff: components/autofill/core/browser/autofill_manager.h

Issue 2124343002: [Autofill] Implement Credit Card Signin Promo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ifdef Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager.h
diff --git a/components/autofill/core/browser/autofill_manager.h b/components/autofill/core/browser/autofill_manager.h
index 2a37e9af4eee86ef13430256b0ea3c4d13e96279..886f04fb29e0f2a06a4538abf971a543f04ec1ee 100644
--- a/components/autofill/core/browser/autofill_manager.h
+++ b/components/autofill/core/browser/autofill_manager.h
@@ -94,6 +94,12 @@ class AutofillManager : public AutofillDownloadManager::Observer,
virtual bool ShouldShowScanCreditCard(const FormData& form,
const FormFieldData& field);
+ // Whether we should show the sign in promo, based on the triggered |field|
Evan Stade 2016/07/08 17:34:58 nit: for consistency, this should be "signin" ever
Mathieu 2016/07/08 18:10:02 Done.
+ // inside the |form|. Will also check whether sign-in is possible for this
Evan Stade 2016/07/08 17:34:58 nit: the last sentence is a bit redundant/confusin
Mathieu 2016/07/08 18:10:02 Done.
+ // user.
+ virtual bool ShouldShowCreditCardSigninPromo(const FormData& form,
+ const FormFieldData& field);
+
// Called from our external delegate so they cannot be private.
virtual void FillOrPreviewForm(AutofillDriver::RendererFormDataAction action,
int query_id,

Powered by Google App Engine
This is Rietveld 408576698