[Autofill] Implement Credit Card Signin Promo

components/autofill/core/browser/autofill_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
 
 #include <deque>
 #include <map>
 #include <memory>
@@ skipping 76 matching lines @@
 
   // Sets an external delegate.
   void SetExternalDelegate(AutofillExternalDelegate* delegate);
 
   void ShowAutofillSettings();
 
   // Whether the |field| should show an entry to scan a credit card.
   virtual bool ShouldShowScanCreditCard(const FormData& form,
                                         const FormFieldData& field);
 
+  // Whether we should show the sign in promo, based on the triggered |field|

[Evan Stade, 2016/07/08 17:34:58]

nit: for consistency, this should be "signin" everywhere and not "sign-in" or
"sign in". ("sign in" is the verb form but I don't see any usages of the verb
here)

[Mathieu, 2016/07/08 18:10:02]

Done.

+  // inside the |form|. Will also check whether sign-in is possible for this

[Evan Stade, 2016/07/08 17:34:58]

nit: the last sentence is a bit redundant/confusing imho

[Mathieu, 2016/07/08 18:10:02]

Done.

+  // user.
+  virtual bool ShouldShowCreditCardSigninPromo(const FormData& form,
+                                               const FormFieldData& field);
+
   // Called from our external delegate so they cannot be private.
   virtual void FillOrPreviewForm(AutofillDriver::RendererFormDataAction action,
                                  int query_id,
                                  const FormData& form,
                                  const FormFieldData& field,
                                  int unique_id);
   virtual void FillCreditCardForm(int query_id,
                                   const FormData& form,
                                   const FormFieldData& field,
                                   const CreditCard& credit_card,
@@ skipping 490 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
                            DontSaveCvcInAutocompleteHistory);
   FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, DontOfferToSavePaymentsCard);
   FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, FillInUpdatedExpirationDate);
   DISALLOW_COPY_AND_ASSIGN(AutofillManager);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_