Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2124283002: Use the outermost SVG as base when computing offsetX/Y for SVG elements (Closed)

Created:
4 years, 5 months ago by fs
Modified:
4 years, 5 months ago
Reviewers:
dtapuska, Rick Byers
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the outermost SVG as base when computing offsetX/Y for SVG elements This reverts the behavior back to what it was prior to https://codereview.chromium.org/1747223002. In short, the closest ancestor CSS layout box is used for any SVG element. This will always be the outermost SVG root (LayoutSVGRoot.) BUG=624996 Committed: https://crrev.com/bb725f3a42fd8caa33c542e46fe4d9fc7a72678f Cr-Commit-Position: refs/heads/master@{#404217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/fast/events/offsetX-offsetY-svg.html View 1 chunk +32 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/MouseRelatedEvent.cpp View 2 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
fs
4 years, 5 months ago (2016-07-07 14:07:09 UTC) #3
dtapuska
On 2016/07/07 14:07:09, fs wrote: lgtm
4 years, 5 months ago (2016-07-07 14:30:48 UTC) #4
Rick Byers
Thanks for the quick fix! LGTM
4 years, 5 months ago (2016-07-07 14:58:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124283002/1
4 years, 5 months ago (2016-07-07 15:24:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 19:48:15 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 19:50:25 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb725f3a42fd8caa33c542e46fe4d9fc7a72678f
Cr-Commit-Position: refs/heads/master@{#404217}

Powered by Google App Engine
This is Rietveld 408576698