Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1747223002: Implement mapAncestorToLocal for LayoutSVG{ModelObject,Block} (Closed)

Created:
4 years, 9 months ago by fs
Modified:
4 years, 9 months ago
Reviewers:
pdr.
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement mapAncestorToLocal for LayoutSVG{ModelObject,Block} This CL adds an implementation of mapAncestorToLocal for SVG LayoutObject types via a helper in SVGLayoutSupport. This should help cases which use any of the LayoutObject::ancestorTo* methods (or similar/wrappers.) Examples of users are various form controls and scrollbars. BUG=568614 Committed: https://crrev.com/a663c6ee1aef79f2de75c7620b72cea48630b9ca Cr-Commit-Position: refs/heads/master@{#378716}

Patch Set 1 #

Patch Set 2 : Avoid potential margin collapsing(?) bug #

Total comments: 2

Patch Set 3 : Add ASSERT for expected types #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -4 lines) Patch
M third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp View 1 1 chunk +103 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 1 2 2 chunks +26 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
fs
4 years, 9 months ago (2016-03-01 14:50:37 UTC) #2
pdr.
LGTM, you are on a roll! https://codereview.chromium.org/1747223002/diff/20001/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp File third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp (right): https://codereview.chromium.org/1747223002/diff/20001/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp#newcode168 third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp:168: // |object| is ...
4 years, 9 months ago (2016-03-01 22:58:39 UTC) #3
fs
https://codereview.chromium.org/1747223002/diff/20001/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp File third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp (right): https://codereview.chromium.org/1747223002/diff/20001/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp#newcode168 third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp:168: // |object| is either a LayoutSVGModelObject or a LayoutSVGBlock ...
4 years, 9 months ago (2016-03-02 08:54:30 UTC) #4
pdr.
On 2016/03/02 at 08:54:30, fs wrote: > https://codereview.chromium.org/1747223002/diff/20001/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp > File third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp (right): > > https://codereview.chromium.org/1747223002/diff/20001/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp#newcode168 ...
4 years, 9 months ago (2016-03-02 09:00:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747223002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747223002/40001
4 years, 9 months ago (2016-03-02 10:29:05 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-02 10:37:09 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 10:39:40 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a663c6ee1aef79f2de75c7620b72cea48630b9ca
Cr-Commit-Position: refs/heads/master@{#378716}

Powered by Google App Engine
This is Rietveld 408576698