Fixed error when normal.z = 1 in GPUs with binary16 floats

Fixed error when normal.z = 1 in GPUs with binary16 floats

Check failed in GPUs with low-precision floats since 0.9999 was too small a difference from 1 to be detected by a 16-bit float comparison. Changed it to 0.999 which fixed the issue and results in indistinguishable correct behavior.


BUG=skia:5499
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2124183004

Committed: https://skia.googlesource.com/skia/+/66ad44a3f1df2547981b97c51d24f6881ba328e0

[dvonbeck, 2016-07-07 21:15:42]

Description was changed from

==========
Fixed error when normal.z = 1 in GPUs with binary16 floats


Addressed remaining patch 8 comments


Addressed some patch 8 comments


Fixed CPU behavior when normal.Z=-1


Removed SkMatrix move to avoid confuion


Resolved TODOs


Fixed GPU first draw bug, nicer style


SkLS now takes in a CTM for normal rotation. GLSL code still buggy


Addressed patch 2 comments


small comment fix


Changed API

BUG=skia:
==========

to

==========
Fixed error when normal.z = 1 in GPUs with binary16 floats


Addressed remaining patch 8 comments


Addressed some patch 8 comments


Fixed CPU behavior when normal.Z=-1


Removed SkMatrix move to avoid confuion


Resolved TODOs


Fixed GPU first draw bug, nicer style


SkLS now takes in a CTM for normal rotation. GLSL code still buggy


Addressed patch 2 comments


small comment fix


Changed API

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2124183004
==========

[dvonbeck, 2016-07-08 14:41:11]

Description was changed from

==========
Fixed error when normal.z = 1 in GPUs with binary16 floats


Addressed remaining patch 8 comments


Addressed some patch 8 comments


Fixed CPU behavior when normal.Z=-1


Removed SkMatrix move to avoid confuion


Resolved TODOs


Fixed GPU first draw bug, nicer style


SkLS now takes in a CTM for normal rotation. GLSL code still buggy


Addressed patch 2 comments


small comment fix


Changed API

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2124183004
==========

to

==========
Fixed error when normal.z = 1 in GPUs with binary16 floats


Addressed remaining patch 8 comments


Addressed some patch 8 comments


Fixed CPU behavior when normal.Z=-1


Removed SkMatrix move to avoid confuion


Resolved TODOs


Fixed GPU first draw bug, nicer style


SkLS now takes in a CTM for normal rotation. GLSL code still buggy


Addressed patch 2 comments


small comment fix


Changed API

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2124183004
==========

[dvonbeck, 2016-07-08 14:41:41]

dvonbeck@google.com changed reviewers:
+ egdaniel@google.com, robertphillips@google.com

[dvonbeck, 2016-07-08 14:42:07]

Description was changed from

==========
Fixed error when normal.z = 1 in GPUs with binary16 floats


Addressed remaining patch 8 comments


Addressed some patch 8 comments


Fixed CPU behavior when normal.Z=-1


Removed SkMatrix move to avoid confuion


Resolved TODOs


Fixed GPU first draw bug, nicer style


SkLS now takes in a CTM for normal rotation. GLSL code still buggy


Addressed patch 2 comments


small comment fix


Changed API

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2124183004
==========

to

==========
Fixed error when normal.z = 1 in GPUs with binary16 floats




BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2124183004
==========

[dvonbeck, 2016-07-08 14:44:15]

Description was changed from

==========
Fixed error when normal.z = 1 in GPUs with binary16 floats




BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2124183004
==========

to

==========
Fixed error when normal.z = 1 in GPUs with binary16 floats

Check failed in GPUs with low-precision floats since 0.9999 was too small a
difference from 1 to be detected by a 16-bit float comparison. Changed it to
0.999 which fixed the issue and results in indistinguishable correct behavior.


BUG=skia:5499
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2124183004
==========

[robertphillips, 2016-07-08 14:53:36]

lgtm

[robertphillips, 2016-07-08 14:53:41]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 14:53:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 15:55:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 15:55:35]

Dry run: This issue passed the CQ dry run.

[dvonbeck, 2016-07-08 15:58:50]

The CQ bit was checked by dvonbeck@google.com

[commit-bot: I haz the power, 2016-07-08 15:58:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 15:59:49]

Description was changed from

==========
Fixed error when normal.z = 1 in GPUs with binary16 floats

Check failed in GPUs with low-precision floats since 0.9999 was too small a
difference from 1 to be detected by a 16-bit float comparison. Changed it to
0.999 which fixed the issue and results in indistinguishable correct behavior.


BUG=skia:5499
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2124183004
==========

to

==========
Fixed error when normal.z = 1 in GPUs with binary16 floats

Check failed in GPUs with low-precision floats since 0.9999 was too small a
difference from 1 to be detected by a 16-bit float comparison. Changed it to
0.999 which fixed the issue and results in indistinguishable correct behavior.


BUG=skia:5499
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2124183004

Committed:
https://skia.googlesource.com/skia/+/66ad44a3f1df2547981b97c51d24f6881ba328e0
==========

[commit-bot: I haz the power, 2016-07-08 15:59:50]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/66ad44a3f1df2547981b97c51d24f6881ba328e0