Remove constructor from remaining functions that aren't constructors

Remove constructor from remaining functions that aren't constructors

BUG=625823
R=haraken@chromium.org,pfeldman@chromium.org

Committed: https://crrev.com/587b0b37724cdfc0eec5ed091b94eb8276bc05ce
Cr-Commit-Position: refs/heads/master@{#404137}

[jochen (gone - plz use gerrit), 2016-07-07 11:05:29]

ptal

Pavel, I'll merge the V8 API to 5.3, 5.2, and 5.1 shortly

[haraken, 2016-07-07 11:12:04]

LGTM

[haraken, 2016-07-07 11:14:09]

https://codereview.chromium.org/2124183003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp (right):

https://codereview.chromium.org/2124183003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp:126:
v8::Local<v8::Value> result = v8::Function::New(isolate->GetCurrentContext(),
throwStackOverflowException, v8::Local<v8::Value>(), 0,
v8::ConstructorBehavior::kThrow).ToLocalChecked()->Call(v8::Undefined(isolate),
0, 0);

Yeah, in reality we want to just crash when V8 API returns an empty Maybe handle
where we don't expect it.

[jochen (gone - plz use gerrit), 2016-07-07 11:25:11]

https://codereview.chromium.org/2124183003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp (right):

https://codereview.chromium.org/2124183003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp:126:
v8::Local<v8::Value> result = v8::Function::New(isolate->GetCurrentContext(),
throwStackOverflowException, v8::Local<v8::Value>(), 0,
v8::ConstructorBehavior::kThrow).ToLocalChecked()->Call(v8::Undefined(isolate),
0, 0);
On 2016/07/07 at 11:14:09, haraken wrote:
> Yeah, in reality we want to just crash when V8 API returns an empty Maybe
handle where we don't expect it.

well, I'm just changing one thing in this CL, and the ->Call() previously also
just crashed on an empty handle.

[jochen (gone - plz use gerrit), 2016-07-07 11:38:05]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-07-07 11:38:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 12:33:49]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-07 12:35:42]

Description was changed from

==========
Remove constructor from remaining functions that aren't constructors

BUG=625823
R=haraken@chromium.org,pfeldman@chromium.org
==========

to

==========
Remove constructor from remaining functions that aren't constructors

BUG=625823
R=haraken@chromium.org,pfeldman@chromium.org

Committed: https://crrev.com/587b0b37724cdfc0eec5ed091b94eb8276bc05ce
Cr-Commit-Position: refs/heads/master@{#404137}
==========

[commit-bot: I haz the power, 2016-07-07 12:35:43]

Patchset 1 (id:??) landed as
https://crrev.com/587b0b37724cdfc0eec5ed091b94eb8276bc05ce
Cr-Commit-Position: refs/heads/master@{#404137}

[jochen (gone - plz use gerrit), 2016-07-12 17:50:26]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2139393002/ by jochen@chromium.org.

The reason for reverting is: Reverting while investigating blob_storage
failures.