Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp

Issue 2124183003: Remove constructor from remaining functions that aren't constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (c) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 296 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 v8::Local<v8::Array> hitBreakpoints; 307 v8::Local<v8::Array> hitBreakpoints;
308 handleProgramBreak(m_pausedContext, m_executionState, exception, hitBrea kpoints); 308 handleProgramBreak(m_pausedContext, m_executionState, exception, hitBrea kpoints);
309 return; 309 return;
310 } 310 }
311 311
312 if (!canBreakProgram()) 312 if (!canBreakProgram())
313 return; 313 return;
314 314
315 v8::HandleScope scope(m_isolate); 315 v8::HandleScope scope(m_isolate);
316 v8::Local<v8::Function> breakFunction; 316 v8::Local<v8::Function> breakFunction;
317 if (!v8::Function::New(m_isolate->GetCurrentContext(), &V8DebuggerImpl::brea kProgramCallback, v8::External::New(m_isolate, this)).ToLocal(&breakFunction)) 317 if (!v8::Function::New(m_isolate->GetCurrentContext(), &V8DebuggerImpl::brea kProgramCallback, v8::External::New(m_isolate, this), 0, v8::ConstructorBehavior ::kThrow).ToLocal(&breakFunction))
318 return; 318 return;
319 v8::Debug::Call(debuggerContext(), breakFunction).ToLocalChecked(); 319 v8::Debug::Call(debuggerContext(), breakFunction).ToLocalChecked();
320 } 320 }
321 321
322 void V8DebuggerImpl::continueProgram() 322 void V8DebuggerImpl::continueProgram()
323 { 323 {
324 if (isPaused()) 324 if (isPaused())
325 m_client->quitMessageLoopOnPause(); 325 m_client->quitMessageLoopOnPause();
326 m_pausedContext.Clear(); 326 m_pausedContext.Clear();
327 m_executionState.Clear(); 327 m_executionState.Clear();
(...skipping 788 matching lines...) Expand 10 before | Expand all | Expand 10 after
1116 1116
1117 V8InspectorSessionImpl* V8DebuggerImpl::sessionForContextGroup(int contextGroupI d) 1117 V8InspectorSessionImpl* V8DebuggerImpl::sessionForContextGroup(int contextGroupI d)
1118 { 1118 {
1119 if (!contextGroupId) 1119 if (!contextGroupId)
1120 return nullptr; 1120 return nullptr;
1121 SessionMap::iterator iter = m_sessions.find(contextGroupId); 1121 SessionMap::iterator iter = m_sessions.find(contextGroupId);
1122 return iter == m_sessions.end() ? nullptr : iter->second; 1122 return iter == m_sessions.end() ? nullptr : iter->second;
1123 } 1123 }
1124 1124
1125 } // namespace blink 1125 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698