Upstream monochrome repack locales

Upstream monochrome repack locales

Reuse chrome_repack_locales template and move webview specific pak
file to a variable, so monochrome will not miss any change

BUG=625028
Committed: https://crrev.com/3be42fae02abfe223b6763389f73cc5b4510d1a9
Cr-Commit-Position: refs/heads/master@{#403986}

[michaelbai, 2016-07-06 19:37:03]

Description was changed from

==========
Upstream monochrome repack locales

Reuse chrome_repack_locales template and move webview specific pak
file to a variable, so monochrome will not miss any change

BUG=625028
==========

to

==========
Upstream monochrome repack locales

Reuse chrome_repack_locales template and move webview specific pak
file to a variable, so monochrome will not miss any change

BUG=625028
==========

[michaelbai, 2016-07-06 19:37:03]

michaelbai@chromium.org changed reviewers:
+ agrieve@chromium.org

[michaelbai, 2016-07-06 19:37:36]

michaelbai@chromium.org changed reviewers:
+ sgurun@chromium.org

[agrieve, 2016-07-06 19:49:17]

lgtm

https://codereview.chromium.org/2124073002/diff/1/chrome/chrome_repack_locale...
File chrome/chrome_repack_locales.gni (right):

https://codereview.chromium.org/2124073002/diff/1/chrome/chrome_repack_locale...
chrome/chrome_repack_locales.gni:198: if (defined(invoker.output_dir)) {
nit: this should be made a part of the above if clause. E.g.

if (defined(invoker.output_dir)) {
  output = ...
} else if (is_mac || is_ios) {
 ...

[michaelbai, 2016-07-06 20:04:39]

michaelbai@chromium.org changed reviewers:
+ nyquist@chromium.org

[michaelbai, 2016-07-06 20:05:17]

nyquist@ need owner approval for chrome/android

https://codereview.chromium.org/2124073002/diff/1/chrome/chrome_repack_locale...
File chrome/chrome_repack_locales.gni (right):

https://codereview.chromium.org/2124073002/diff/1/chrome/chrome_repack_locale...
chrome/chrome_repack_locales.gni:198: if (defined(invoker.output_dir)) {
On 2016/07/06 19:49:17, agrieve wrote:
> nit: this should be made a part of the above if clause. E.g.
> 
> if (defined(invoker.output_dir)) {
>   output = ...
> } else if (is_mac || is_ios) {
>  ...

Done.

[sgurun-gerrit only, 2016-07-06 21:25:59]

On 2016/07/06 20:05:17, michaelbai wrote:
> nyquist@ need owner approval for chrome/android
> 
>
https://codereview.chromium.org/2124073002/diff/1/chrome/chrome_repack_locale...
> File chrome/chrome_repack_locales.gni (right):
> 
>
https://codereview.chromium.org/2124073002/diff/1/chrome/chrome_repack_locale...
> chrome/chrome_repack_locales.gni:198: if (defined(invoker.output_dir)) {
> On 2016/07/06 19:49:17, agrieve wrote:
> > nit: this should be made a part of the above if clause. E.g.
> > 
> > if (defined(invoker.output_dir)) {
> >   output = ...
> > } else if (is_mac || is_ios) {
> >  ...
> 
> Done.

lgtm

[nyquist, 2016-07-06 21:37:04]

lgtm

[michaelbai, 2016-07-06 21:42:15]

The CQ bit was checked by michaelbai@chromium.org

[michaelbai, 2016-07-06 21:42:15]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2124073002/#ps20001
(title: "address comment")

[commit-bot: I haz the power, 2016-07-06 21:42:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 23:52:08]

Description was changed from

==========
Upstream monochrome repack locales

Reuse chrome_repack_locales template and move webview specific pak
file to a variable, so monochrome will not miss any change

BUG=625028
==========

to

==========
Upstream monochrome repack locales

Reuse chrome_repack_locales template and move webview specific pak
file to a variable, so monochrome will not miss any change

BUG=625028
==========

[commit-bot: I haz the power, 2016-07-06 23:52:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-06 23:52:22]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-06 23:54:30]

Description was changed from

==========
Upstream monochrome repack locales

Reuse chrome_repack_locales template and move webview specific pak
file to a variable, so monochrome will not miss any change

BUG=625028
==========

to

==========
Upstream monochrome repack locales

Reuse chrome_repack_locales template and move webview specific pak
file to a variable, so monochrome will not miss any change

BUG=625028

Committed: https://crrev.com/3be42fae02abfe223b6763389f73cc5b4510d1a9
Cr-Commit-Position: refs/heads/master@{#403986}
==========

[commit-bot: I haz the power, 2016-07-06 23:54:32]

Patchset 2 (id:??) landed as
https://crrev.com/3be42fae02abfe223b6763389f73cc5b4510d1a9
Cr-Commit-Position: refs/heads/master@{#403986}