Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1905)

Unified Diff: android_webview/webview_repack_locales.gni

Issue 2124073002: Upstream monochrome repack locales (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/webview_repack_locales_list.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/webview_repack_locales.gni
diff --git a/android_webview/webview_repack_locales.gni b/android_webview/webview_repack_locales.gni
index c739c122b0715fb1c2fa97de4b7ca6ce0b3d61bc..33b90a167d6845af56c978db3f1e9d28ed9ca426 100644
--- a/android_webview/webview_repack_locales.gni
+++ b/android_webview/webview_repack_locales.gni
@@ -9,6 +9,7 @@ import("//build/config/chrome_build.gni")
import("//build/config/features.gni")
import("//build/config/ui.gni")
import("//tools/grit/repack.gni")
+import("webview_repack_locales_list.gni")
# Arguments:
#
@@ -26,17 +27,22 @@ template("_repack_one_locale") {
repack(target_name) {
visibility = invoker.visibility
+ # Adding webview specific pak file? You should add it to
+ # webview_repack_locales_source_patterns, so it is also included in
+ # Monochrome.
+
# Each input pak file should also have a deps line for completeness.
sources = [
- "${root_gen_dir}/android_webview/aw_strings_${locale}.pak",
"${root_gen_dir}/android_webview/components_strings_${locale}.pak",
"${root_gen_dir}/content/app/strings/content_strings_${locale}.pak",
]
deps = [
- "//android_webview:generate_aw_strings",
"//android_webview:generate_components_strings",
"//content/app/strings",
]
+ sources += process_file_template(webview_repack_locales_source_patterns,
+ [ "{{source}}_${locale}.pak" ])
+ deps += webview_repack_locales_deps
output = invoker.output
}
}
« no previous file with comments | « no previous file | android_webview/webview_repack_locales_list.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698