[turbofan] Add MachineType to LinkageLocation

[turbofan] Add MachineType to LinkageLocation

By adding MachineType to LinkageLocation, it is possible not only to reason
about the location of a LinkageLocation on the stack, but also about it's
size. This will be useful in follow-on CLs that attempt to merge some of the
parameter passing logic of tail calls and normal (non-tail) calls.

As a nice side-effect, it is no longer necessary to separately keep a
MachineSignature in a CallDescriptor, because the MachineTypes contianed in
LinkageLocation for all of the Descriptor's parameters and return types are
sufficient. This CL therefore removes the MachineSignature from the
CallDescriptor and adjusts all the calling code accordingly, simplifying and
de-duplicating code in a bunch of places.

R=titzer@chromium.org, bmeurer@chromium.org
LOG=N

Committed: https://crrev.com/3e2085eba411515969e988d55fa8767e1d05f714
Cr-Commit-Position: refs/heads/master@{#37633}

[danno, 2016-07-07 10:59:37]

Description was changed from

==========
[turbofan] Add MachineType to LinkageLocation

By adding MachineType to LinkageLocation, it is possible not only to reason
about the location of a LinkageLocation on the stack, but also about it's
size. This will be useful in follow-on CLs that attempt to merge some of the
parameter passing logic of tail calls and normal (non-tail) calls.

As a nice side-effect, it is no longer necessary to separately keep a
MachineSignature in a CallDescriptor, because the MachienTypes contianed in
LinkageLocation for all of the Descriptor's parameters and return types are
sufficient. This CL therefore removes the MachineSignature from the
CallDescriptor and adjusts all the calling code accordingly, simplifying and
de-duplicating code in a bunch of places.

R=titzer@chromium.org, bmeurer@chromium.org
LOG=N
==========

to

==========
[turbofan] Add MachineType to LinkageLocation

By adding MachineType to LinkageLocation, it is possible not only to reason
about the location of a LinkageLocation on the stack, but also about it's
size. This will be useful in follow-on CLs that attempt to merge some of the
parameter passing logic of tail calls and normal (non-tail) calls.

As a nice side-effect, it is no longer necessary to separately keep a
MachineSignature in a CallDescriptor, because the MachineTypes contianed in
LinkageLocation for all of the Descriptor's parameters and return types are
sufficient. This CL therefore removes the MachineSignature from the
CallDescriptor and adjusts all the calling code accordingly, simplifying and
de-duplicating code in a bunch of places.

R=titzer@chromium.org, bmeurer@chromium.org
LOG=N
==========

[danno, 2016-07-07 11:07:17]

PTAL

[danno, 2016-07-07 13:07:08]

danno@chromium.org changed reviewers:
+ jarin@chromium.org

[titzer, 2016-07-08 07:46:23]

lgtm! Nice simplification. Should have been that way from the beginning.

https://codereview.chromium.org/2124023003/diff/40001/src/compiler/linkage.cc
File src/compiler/linkage.cc (right):

https://codereview.chromium.org/2124023003/diff/40001/src/compiler/linkage.cc...
src/compiler/linkage.cc:260: regloc(kRuntimeCallArgCountRegister,
MachineType::Pointer()));
Is this one a SMI?

https://codereview.chromium.org/2124023003/diff/40001/src/compiler/linkage.h
File src/compiler/linkage.h (right):

https://codereview.chromium.org/2124023003/diff/40001/src/compiler/linkage.h#...
src/compiler/linkage.h:127: DCHECK((GetSize() % kPointerSize) == 0);
Why not just round up if it's less than pointer size?

https://codereview.chromium.org/2124023003/diff/40001/src/compiler/wasm-linka...
File src/compiler/wasm-linkage.cc (right):

https://codereview.chromium.org/2124023003/diff/40001/src/compiler/wasm-linka...
src/compiler/wasm-linkage.cc:44: // Platform-specific configuration for C
calling convention.
Comment is wrong here.

[danno, 2016-07-08 15:22:10]

Feedback addressed, landing...

https://codereview.chromium.org/2124023003/diff/40001/src/compiler/linkage.cc
File src/compiler/linkage.cc (right):

https://codereview.chromium.org/2124023003/diff/40001/src/compiler/linkage.cc...
src/compiler/linkage.cc:260: regloc(kRuntimeCallArgCountRegister,
MachineType::Pointer()));
On 2016/07/08 07:46:22, titzer wrote:
> Is this one a SMI?

Done.

https://codereview.chromium.org/2124023003/diff/40001/src/compiler/linkage.h
File src/compiler/linkage.h (right):

https://codereview.chromium.org/2124023003/diff/40001/src/compiler/linkage.h#...
src/compiler/linkage.h:127: DCHECK((GetSize() % kPointerSize) == 0);
On 2016/07/08 07:46:23, titzer wrote:
> Why not just round up if it's less than pointer size?

Done.

https://codereview.chromium.org/2124023003/diff/40001/src/compiler/wasm-linka...
File src/compiler/wasm-linkage.cc (right):

https://codereview.chromium.org/2124023003/diff/40001/src/compiler/wasm-linka...
src/compiler/wasm-linkage.cc:44: // Platform-specific configuration for C
calling convention.
On 2016/07/08 07:46:23, titzer wrote:
> Comment is wrong here.

Done.

[Benedikt Meurer, 2016-07-09 17:54:48]

Nice, LGTM.

On a related note: We should replace the use of Type* in CallInterfaceDescriptor
with MachineRepresentation.

[danno, 2016-07-11 10:02:19]

The CQ bit was checked by danno@chromium.org

[danno, 2016-07-11 10:02:19]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2124023003/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-11 10:02:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 10:37:29]

Description was changed from

==========
[turbofan] Add MachineType to LinkageLocation

By adding MachineType to LinkageLocation, it is possible not only to reason
about the location of a LinkageLocation on the stack, but also about it's
size. This will be useful in follow-on CLs that attempt to merge some of the
parameter passing logic of tail calls and normal (non-tail) calls.

As a nice side-effect, it is no longer necessary to separately keep a
MachineSignature in a CallDescriptor, because the MachineTypes contianed in
LinkageLocation for all of the Descriptor's parameters and return types are
sufficient. This CL therefore removes the MachineSignature from the
CallDescriptor and adjusts all the calling code accordingly, simplifying and
de-duplicating code in a bunch of places.

R=titzer@chromium.org, bmeurer@chromium.org
LOG=N
==========

to

==========
[turbofan] Add MachineType to LinkageLocation

By adding MachineType to LinkageLocation, it is possible not only to reason
about the location of a LinkageLocation on the stack, but also about it's
size. This will be useful in follow-on CLs that attempt to merge some of the
parameter passing logic of tail calls and normal (non-tail) calls.

As a nice side-effect, it is no longer necessary to separately keep a
MachineSignature in a CallDescriptor, because the MachineTypes contianed in
LinkageLocation for all of the Descriptor's parameters and return types are
sufficient. This CL therefore removes the MachineSignature from the
CallDescriptor and adjusts all the calling code accordingly, simplifying and
de-duplicating code in a bunch of places.

R=titzer@chromium.org, bmeurer@chromium.org
LOG=N
==========

[commit-bot: I haz the power, 2016-07-11 10:37:30]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-11 10:39:43]

Description was changed from

==========
[turbofan] Add MachineType to LinkageLocation

By adding MachineType to LinkageLocation, it is possible not only to reason
about the location of a LinkageLocation on the stack, but also about it's
size. This will be useful in follow-on CLs that attempt to merge some of the
parameter passing logic of tail calls and normal (non-tail) calls.

As a nice side-effect, it is no longer necessary to separately keep a
MachineSignature in a CallDescriptor, because the MachineTypes contianed in
LinkageLocation for all of the Descriptor's parameters and return types are
sufficient. This CL therefore removes the MachineSignature from the
CallDescriptor and adjusts all the calling code accordingly, simplifying and
de-duplicating code in a bunch of places.

R=titzer@chromium.org, bmeurer@chromium.org
LOG=N
==========

to

==========
[turbofan] Add MachineType to LinkageLocation

By adding MachineType to LinkageLocation, it is possible not only to reason
about the location of a LinkageLocation on the stack, but also about it's
size. This will be useful in follow-on CLs that attempt to merge some of the
parameter passing logic of tail calls and normal (non-tail) calls.

As a nice side-effect, it is no longer necessary to separately keep a
MachineSignature in a CallDescriptor, because the MachineTypes contianed in
LinkageLocation for all of the Descriptor's parameters and return types are
sufficient. This CL therefore removes the MachineSignature from the
CallDescriptor and adjusts all the calling code accordingly, simplifying and
de-duplicating code in a bunch of places.

R=titzer@chromium.org, bmeurer@chromium.org
LOG=N

Committed: https://crrev.com/3e2085eba411515969e988d55fa8767e1d05f714
Cr-Commit-Position: refs/heads/master@{#37633}
==========

[commit-bot: I haz the power, 2016-07-11 10:39:44]

Patchset 5 (id:??) landed as
https://crrev.com/3e2085eba411515969e988d55fa8767e1d05f714
Cr-Commit-Position: refs/heads/master@{#37633}