Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/unittests/compiler/tail-call-optimization-unittest.cc

Issue 2124023003: [turbofan] Add MachineType to LinkageLocation (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/unittests/compiler/linkage-tail-call-unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/tail-call-optimization-unittest.cc
diff --git a/test/unittests/compiler/tail-call-optimization-unittest.cc b/test/unittests/compiler/tail-call-optimization-unittest.cc
index 3441c68b961090cae49bba8d8c497d9c8f4066c0..3c0f8c6139058e4c7b7dc8c0bef9d1e5bfd6f7c2 100644
--- a/test/unittests/compiler/tail-call-optimization-unittest.cc
+++ b/test/unittests/compiler/tail-call-optimization-unittest.cc
@@ -26,14 +26,12 @@ class TailCallOptimizationTest : public GraphTest {
TEST_F(TailCallOptimizationTest, CallCodeObject0) {
- MachineType kMachineSignature[] = {MachineType::AnyTagged(),
- MachineType::AnyTagged()};
- LinkageLocation kLocationSignature[] = {LinkageLocation::ForRegister(0),
- LinkageLocation::ForRegister(1)};
+ LinkageLocation kLocationSignature[] = {
+ LinkageLocation::ForRegister(0, MachineType::Pointer()),
+ LinkageLocation::ForRegister(1, MachineType::Pointer())};
const CallDescriptor* kCallDescriptor = new (zone()) CallDescriptor(
CallDescriptor::kCallCodeObject, MachineType::AnyTagged(),
- LinkageLocation::ForRegister(0),
- new (zone()) MachineSignature(1, 1, kMachineSignature),
+ LinkageLocation::ForRegister(0, MachineType::Pointer()),
new (zone()) LocationSignature(1, 1, kLocationSignature), 0,
Operator::kNoProperties, 0, 0, CallDescriptor::kNoFlags);
Node* p0 = Parameter(0);
@@ -48,14 +46,12 @@ TEST_F(TailCallOptimizationTest, CallCodeObject0) {
TEST_F(TailCallOptimizationTest, CallCodeObject1) {
- MachineType kMachineSignature[] = {MachineType::AnyTagged(),
- MachineType::AnyTagged()};
- LinkageLocation kLocationSignature[] = {LinkageLocation::ForRegister(0),
- LinkageLocation::ForRegister(1)};
+ LinkageLocation kLocationSignature[] = {
+ LinkageLocation::ForRegister(0, MachineType::Pointer()),
+ LinkageLocation::ForRegister(1, MachineType::Pointer())};
const CallDescriptor* kCallDescriptor = new (zone()) CallDescriptor(
CallDescriptor::kCallCodeObject, MachineType::AnyTagged(),
- LinkageLocation::ForRegister(0),
- new (zone()) MachineSignature(1, 1, kMachineSignature),
+ LinkageLocation::ForRegister(0, MachineType::Pointer()),
new (zone()) LocationSignature(1, 1, kLocationSignature), 0,
Operator::kNoProperties, 0, 0, CallDescriptor::kSupportsTailCalls);
Node* p0 = Parameter(0);
@@ -74,14 +70,12 @@ TEST_F(TailCallOptimizationTest, CallCodeObject1) {
TEST_F(TailCallOptimizationTest, CallCodeObject2) {
- MachineType kMachineSignature[] = {MachineType::AnyTagged(),
- MachineType::AnyTagged()};
- LinkageLocation kLocationSignature[] = {LinkageLocation::ForRegister(0),
- LinkageLocation::ForRegister(1)};
+ LinkageLocation kLocationSignature[] = {
+ LinkageLocation::ForRegister(0, MachineType::Pointer()),
+ LinkageLocation::ForRegister(1, MachineType::Pointer())};
const CallDescriptor* kCallDescriptor = new (zone()) CallDescriptor(
CallDescriptor::kCallCodeObject, MachineType::AnyTagged(),
- LinkageLocation::ForRegister(0),
- new (zone()) MachineSignature(1, 1, kMachineSignature),
+ LinkageLocation::ForRegister(0, MachineType::Pointer()),
new (zone()) LocationSignature(1, 1, kLocationSignature), 0,
Operator::kNoProperties, 0, 0, CallDescriptor::kSupportsTailCalls);
Node* p0 = Parameter(0);
@@ -98,14 +92,12 @@ TEST_F(TailCallOptimizationTest, CallCodeObject2) {
TEST_F(TailCallOptimizationTest, CallJSFunction0) {
- MachineType kMachineSignature[] = {MachineType::AnyTagged(),
- MachineType::AnyTagged()};
- LinkageLocation kLocationSignature[] = {LinkageLocation::ForRegister(0),
- LinkageLocation::ForRegister(1)};
+ LinkageLocation kLocationSignature[] = {
+ LinkageLocation::ForRegister(0, MachineType::Pointer()),
+ LinkageLocation::ForRegister(1, MachineType::Pointer())};
const CallDescriptor* kCallDescriptor = new (zone()) CallDescriptor(
CallDescriptor::kCallJSFunction, MachineType::AnyTagged(),
- LinkageLocation::ForRegister(0),
- new (zone()) MachineSignature(1, 1, kMachineSignature),
+ LinkageLocation::ForRegister(0, MachineType::Pointer()),
new (zone()) LocationSignature(1, 1, kLocationSignature), 0,
Operator::kNoProperties, 0, 0, CallDescriptor::kNoFlags);
Node* p0 = Parameter(0);
@@ -120,14 +112,12 @@ TEST_F(TailCallOptimizationTest, CallJSFunction0) {
TEST_F(TailCallOptimizationTest, CallJSFunction1) {
- MachineType kMachineSignature[] = {MachineType::AnyTagged(),
- MachineType::AnyTagged()};
- LinkageLocation kLocationSignature[] = {LinkageLocation::ForRegister(0),
- LinkageLocation::ForRegister(1)};
+ LinkageLocation kLocationSignature[] = {
+ LinkageLocation::ForRegister(0, MachineType::Pointer()),
+ LinkageLocation::ForRegister(1, MachineType::Pointer())};
const CallDescriptor* kCallDescriptor = new (zone()) CallDescriptor(
CallDescriptor::kCallJSFunction, MachineType::AnyTagged(),
LinkageLocation::ForRegister(0),
- new (zone()) MachineSignature(1, 1, kMachineSignature),
new (zone()) LocationSignature(1, 1, kLocationSignature), 0,
Operator::kNoProperties, 0, 0, CallDescriptor::kSupportsTailCalls);
Node* p0 = Parameter(0);
@@ -146,14 +136,11 @@ TEST_F(TailCallOptimizationTest, CallJSFunction1) {
TEST_F(TailCallOptimizationTest, CallJSFunction2) {
- MachineType kMachineSignature[] = {MachineType::AnyTagged(),
- MachineType::AnyTagged()};
LinkageLocation kLocationSignature[] = {LinkageLocation::ForRegister(0),
LinkageLocation::ForRegister(1)};
const CallDescriptor* kCallDescriptor = new (zone()) CallDescriptor(
CallDescriptor::kCallJSFunction, MachineType::AnyTagged(),
LinkageLocation::ForRegister(0),
- new (zone()) MachineSignature(1, 1, kMachineSignature),
new (zone()) LocationSignature(1, 1, kLocationSignature), 0,
Operator::kNoProperties, 0, 0, CallDescriptor::kSupportsTailCalls);
Node* p0 = Parameter(0);
« no previous file with comments | « test/unittests/compiler/linkage-tail-call-unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698