Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2123973004: Define a minimum time for double tap in ChromeVox. (Closed)

Created:
4 years, 5 months ago by David Tseng
Modified:
4 years, 5 months ago
Reviewers:
nektarios
CC:
aboxhall+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Define a minimum time for double tap in ChromeVox. TEST=flash Chromebook; hold search key and verify we're not repeatedly toggling sticky mode. BUG=617748 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/9e0ab467434123946f1cf936257af2fbbc9ca555 Cr-Commit-Position: refs/heads/master@{#404305}

Patch Set 1 #

Patch Set 2 : Fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -9 lines) Patch
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 1 5 chunks +29 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/key_util.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/notifications.js View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
David Tseng
4 years, 5 months ago (2016-07-07 17:56:19 UTC) #4
chromium-reviews
--- a/chrome/browser/resources/chromeos/chromevox/common/key_util.js > > - if (prevTime > 0 && currTime - prevTime < 300) ...
4 years, 5 months ago (2016-07-07 18:20:45 UTC) #5
nektarios
lgtm
4 years, 5 months ago (2016-07-07 18:21:08 UTC) #6
David Tseng
On Thu, Jul 7, 2016 at 11:20 AM, 'Nektarios Paisios' via Chromium-reviews < chromium-reviews@chromium.org> wrote: ...
4 years, 5 months ago (2016-07-07 18:37:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123973004/20001
4 years, 5 months ago (2016-07-07 21:21:52 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-07 23:23:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123973004/20001
4 years, 5 months ago (2016-07-08 01:47:55 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-08 01:52:51 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 01:52:53 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 01:54:22 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9e0ab467434123946f1cf936257af2fbbc9ca555
Cr-Commit-Position: refs/heads/master@{#404305}

Powered by Google App Engine
This is Rietveld 408576698