Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2512)

Unified Diff: chrome/browser/resources/chromeos/chromevox/common/key_util.js

Issue 2123973004: Define a minimum time for double tap in ChromeVox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/common/key_util.js
diff --git a/chrome/browser/resources/chromeos/chromevox/common/key_util.js b/chrome/browser/resources/chromeos/chromevox/common/key_util.js
index e823efe5a99bb8f7590846e60b98f56520019e42..1f64d1cbeb84bcc84e7f3ecdbbfb980d24108313 100644
--- a/chrome/browser/resources/chromeos/chromevox/common/key_util.js
+++ b/chrome/browser/resources/chromeos/chromevox/common/key_util.js
@@ -118,7 +118,8 @@ cvox.KeyUtil.keyEventToKeySequence = function(keyEvent) {
util.prevKeySequence &&
keySequence.equals(util.prevKeySequence)) {
var prevTime = util.modeKeyPressTime;
- if (prevTime > 0 && currTime - prevTime < 300) { // Double tap
+ var delta = currTime - prevTime;
+ if (prevTime > 0 && delta > 100 && delta < 300) { // Double tap
keySequence = util.prevKeySequence;
keySequence.doubleTap = true;
util.prevKeySequence = null;

Powered by Google App Engine
This is Rietveld 408576698