Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2123963003: Add a comment about why HTMLObjectElement inherits FormAssociatedElement (Closed)

Created:
4 years, 5 months ago by kochi
Modified:
4 years, 5 months ago
Reviewers:
tkent, dcheng
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a comment about why HTMLObjectElement inherits FormAssociatedElement NOTRY=true Committed: https://crrev.com/0024dfc8a1eeb0d179c6945d3b752e45416eb200 Cr-Commit-Position: refs/heads/master@{#404110}

Patch Set 1 #

Patch Set 2 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/html/HTMLObjectElement.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
kochi
I spent a while why HTMLObjectElement inherits FormAssociatedElement, and figured out that it was used ...
4 years, 5 months ago (2016-07-07 08:25:07 UTC) #3
dcheng
LGTM Sorry I should have added this comment when I did the initial investigation. Thanks!
4 years, 5 months ago (2016-07-07 09:12:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123963003/20001
4 years, 5 months ago (2016-07-07 09:18:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-07 09:21:55 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 09:22:02 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 09:23:27 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0024dfc8a1eeb0d179c6945d3b752e45416eb200
Cr-Commit-Position: refs/heads/master@{#404110}

Powered by Google App Engine
This is Rietveld 408576698