Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1844383003: Remove NPAPI support for form data (Closed)

Created:
4 years, 8 months ago by piman
Modified:
4 years, 8 months ago
Reviewers:
dcheng
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, sigbjorn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove NPAPI support for form data Since PPAPI doesn't support it either, remove (some of) the corresponding blink code. BUG=493212 Committed: https://crrev.com/697d42b85a7a8e9f345d26bb99576c26b7d268a5 Cr-Commit-Position: refs/heads/master@{#384485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -91 lines) Patch
M content/child/npapi/plugin_instance.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/npapi/plugin_instance.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M content/child/npapi/webplugin_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/child/npapi/webplugin_delegate_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/npapi/webplugin_delegate_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/child/plugin_messages.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/plugin/webplugin_delegate_stub.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/plugin/webplugin_delegate_stub.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/plugins/PluginView.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/public/web/WebPlugin.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
piman
dcheng: please review. sigbjorn: FYI, from the logs it looks like you touched the form ...
4 years, 8 months ago (2016-04-01 03:03:26 UTC) #2
dcheng
lgtm
4 years, 8 months ago (2016-04-01 03:20:17 UTC) #3
dcheng
(I think you're right about FormAssociatedElement, but let's do that in a separate CL)
4 years, 8 months ago (2016-04-01 03:21:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844383003/1
4 years, 8 months ago (2016-04-01 04:35:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 04:45:47 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/697d42b85a7a8e9f345d26bb99576c26b7d268a5 Cr-Commit-Position: refs/heads/master@{#384485}
4 years, 8 months ago (2016-04-01 04:47:29 UTC) #9
dcheng
4 years, 8 months ago (2016-04-01 04:56:10 UTC) #10
Message was sent while issue was closed.
OK, maybe not: the spec defines some of this behavior, so even though it's a
no-op, we'll probably have to leave it.

https://html.spec.whatwg.org/multipage/embedded-content.html#the-object-element

Powered by Google App Engine
This is Rietveld 408576698