server/cmd/logdog_collector/main.go - Issue 2123853002: Added unit annotation supports onto tsmon in go.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: server/cmd/logdog_collector/main.go

Issue 2123853002: Added unit annotation supports onto tsmon in go. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: server/cmd/logdog_collector/main.go

diff --git a/server/cmd/logdog_collector/main.go b/server/cmd/logdog_collector/main.go

index 809e6c7b42f08be19afcd39d9e13ca466d405fb2..ec86b89f8d67c4618502b0dc11c06091673aa69d 100644

--- a/server/cmd/logdog_collector/main.go

+++ b/server/cmd/logdog_collector/main.go

@@ -17,6 +17,7 @@ import (

"github.com/luci/luci-go/common/tsmon/distribution"

"github.com/luci/luci-go/common/tsmon/field"

"github.com/luci/luci-go/common/tsmon/metric"

+ "github.com/luci/luci-go/common/tsmon/types"

"github.com/luci/luci-go/server/internal/logdog/collector"

"github.com/luci/luci-go/server/internal/logdog/collector/coordinator"

"github.com/luci/luci-go/server/internal/logdog/service"

@@ -42,12 +43,14 @@ var (

// "transient_failure".

tsPubsubCount = metric.NewCounter("logdog/collector/subscription/count",

"The number of Pub/Sub messages pulled.",

+ types.MetricMetadata{},

field.String("result"))

// tsTaskProcessingTime tracks the amount of time a single subscription

// message takes to process, in milliseconds.

tsTaskProcessingTime = metric.NewCumulativeDistribution("logdog/collector/subscription/processing_time_ms",

"Amount of time in milliseconds that a single Pub/Sub message takes to process.",

+ types.MetricMetadata{},

Sergey Berezin 2016/07/06 21:39:12 Should this be Units: types.Milliseconds ?

ddoman 2016/07/07 04:47:57 Good catch! Fixed.

distribution.DefaultBucketer)

)

« no previous file with comments | « server/cmd/logdog_archivist/main.go ('k') | server/internal/logdog/archivist/archivist.go » ('j') | no next file with comments »