Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1275)

Unified Diff: testing/android/proguard_for_test.flags

Issue 2123753005: Creating new gn arg: enable_all_proguard_optimizations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/android/rules.gni ('K') | « build/config/android/rules.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/android/proguard_for_test.flags
diff --git a/testing/android/proguard_for_test.flags b/testing/android/proguard_for_test.flags
new file mode 100644
index 0000000000000000000000000000000000000000..24e7ccd678167496ceb99e714b0808f653a4f8c6
--- /dev/null
+++ b/testing/android/proguard_for_test.flags
@@ -0,0 +1,12 @@
+# Copyright (c) 2016 The Chromium Authors. All rights reserved.
agrieve 2016/07/07 01:32:13 nit: we don't put the (c) in anymore :P
smaier 2016/07/07 15:05:05 Done.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# This file is for proguard flags which will be applied to apks that are being
+# built to be instrumentation tested. The flags in this file should only affect
+# how the instrumentation tests interact with the .apk. Do not put any flags in
+# this file which might affect the correctness of the .apk.
+
+# We don't optimize to prevent inlining functions our instrumentation tests rely
+# on.
+-dontoptimize
jbudorick 2016/07/07 01:48:52 Does this need to be in its own file? Can we pass
agrieve 2016/07/07 13:37:57 I made the same comment in person, and Sam pointed
« build/config/android/rules.gni ('K') | « build/config/android/rules.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698