testing/android/proguard_for_test.flags - Issue 2123753005: Creating new gn arg: enable_all_proguard_optimizations.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: testing/android/proguard_for_test.flags

Issue 2123753005: Creating new gn arg: enable_all_proguard_optimizations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright (c) 2016 The Chromium Authors. All rights reserved.
	agrieve 2016/07/07 01:32:13 nit: we don't put the (c) in anymore :P nit: we don't put the (c) in anymore :P smaier 2016/07/07 15:05:05 Done. Show quoted text On 2016/07/07 01:32:13, agrieve wrote: > nit: we don't put the (c) in anymore :P Done.
	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 # This file is for proguard flags which will be applied to apks that are being

	6 # built to be instrumentation tested. The flags in this file should only affect

	7 # how the instrumentation tests interact with the .apk. Do not put any flags in

	8 # this file which might affect the correctness of the .apk.

	9

	10 # We don't optimize to prevent inlining functions our instrumentation tests rely

	11 # on.

	12 -dontoptimize
	jbudorick 2016/07/07 01:48:52 Does this need to be in its own file? Can we pass Does this need to be in its own file? Can we pass it inline? agrieve 2016/07/07 13:37:57 I made the same comment in person, and Sam pointed Show quoted text On 2016/07/07 01:48:52, jbudorick wrote: > Does this need to be in its own file? Can we pass it inline? I made the same comment in person, and Sam pointed out that we'll also want to move the @VisibleForTesting -keeps in here next (and friends)
OLD	NEW

« build/config/android/rules.gni ('K') | « build/config/android/rules.gni ('k') | no next file » | no next file with comments »