Rename PermissionBubbleRequest to PermissionRequest

Rename PermissionBubbleRequest to PermissionRequest

Additionally moves PermissionRequest from chrome/browser/ui/ to
chrome/browser/permissions and renames some helper/test classes. This is
a step towards being able to share generic permission request handling
code between Bubbles on desktop and InfoBars on Android.

This CL is a rebased and updated version of
https://codereview.chromium.org/1689513002/ by mlamouri@chromium.org

BUG=606138
Committed: https://crrev.com/58defcfb180432d2d1335f8b06766c2b4d746a3f
Cr-Commit-Position: refs/heads/master@{#406418}

[tsergeant, 2016-07-14 05:13:34]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 05:13:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 06:17:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 06:17:15]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-07-15 04:35:58]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 04:36:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 04:53:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 04:53:38]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[tsergeant, 2016-07-15 06:03:29]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 06:03:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 07:07:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 07:07:30]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-07-15 08:28:58]

Patchset #3 (id:40001) has been deleted

[tsergeant, 2016-07-15 08:29:13]

Patchset #4 (id:80001) has been deleted

[tsergeant, 2016-07-15 08:31:22]

tsergeant@chromium.org changed reviewers:
+ felt@chromium.org

[tsergeant, 2016-07-15 08:31:23]

+felt: Can you please take a look at this one too?

[felt, 2016-07-15 17:35:16]

https://codereview.chromium.org/2123653006/diff/100001/chrome/browser/permiss...
File chrome/browser/permissions/mock_permission_request.h (right):

https://codereview.chromium.org/2123653006/diff/100001/chrome/browser/permiss...
chrome/browser/permissions/mock_permission_request.h:44: PermissionBubbleType
bubble_type);
What are you planning to do with PermissionBubbleTypes?

[tsergeant, 2016-07-18 01:27:47]

https://codereview.chromium.org/2123653006/diff/100001/chrome/browser/permiss...
File chrome/browser/permissions/mock_permission_request.h (right):

https://codereview.chromium.org/2123653006/diff/100001/chrome/browser/permiss...
chrome/browser/permissions/mock_permission_request.h:44: PermissionBubbleType
bubble_type);
On 2016/07/15 17:35:16, felt wrote:
> What are you planning to do with PermissionBubbleTypes?

Plan is to rename to PermissionRequestType. I was going to do that separately,
but I can do it in this CL if you prefer (particularly since I'm touching all
the relevant files already).

[felt, 2016-07-18 04:17:17]

https://codereview.chromium.org/2123653006/diff/100001/chrome/browser/permiss...
File chrome/browser/permissions/mock_permission_request.h (right):

https://codereview.chromium.org/2123653006/diff/100001/chrome/browser/permiss...
chrome/browser/permissions/mock_permission_request.h:44: PermissionBubbleType
bubble_type);
On 2016/07/18 01:27:47, tsergeant wrote:
> On 2016/07/15 17:35:16, felt wrote:
> > What are you planning to do with PermissionBubbleTypes?
> 
> Plan is to rename to PermissionRequestType. I was going to do that separately,
> but I can do it in this CL if you prefer (particularly since I'm touching all
> the relevant files already).

If it's contained within all the same files, I think it would make sense to do
in this CL too. Could you please go ahead and add it?

[tsergeant, 2016-07-18 05:03:02]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 05:03:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 06:47:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 06:47:14]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[tsergeant, 2016-07-18 06:55:29]

https://codereview.chromium.org/2123653006/diff/100001/chrome/browser/permiss...
File chrome/browser/permissions/mock_permission_request.h (right):

https://codereview.chromium.org/2123653006/diff/100001/chrome/browser/permiss...
chrome/browser/permissions/mock_permission_request.h:44: PermissionBubbleType
bubble_type);
On 2016/07/18 04:17:17, felt wrote:
> On 2016/07/18 01:27:47, tsergeant wrote:
> > On 2016/07/15 17:35:16, felt wrote:
> > > What are you planning to do with PermissionBubbleTypes?
> > 
> > Plan is to rename to PermissionRequestType. I was going to do that
separately,
> > but I can do it in this CL if you prefer (particularly since I'm touching
all
> > the relevant files already).
> 
> If it's contained within all the same files, I think it would make sense to do
> in this CL too. Could you please go ahead and add it?

Done.

[felt, 2016-07-19 00:21:29]

https://codereview.chromium.org/2123653006/diff/120001/chrome/browser/permiss...
File chrome/browser/permissions/mock_permission_request.h (right):

https://codereview.chromium.org/2123653006/diff/120001/chrome/browser/permiss...
chrome/browser/permissions/mock_permission_request.h:44: PermissionRequestType
bubble_type);
nit: request_type

https://codereview.chromium.org/2123653006/diff/120001/chrome/browser/permiss...
chrome/browser/permissions/mock_permission_request.h:48: PermissionRequestType
bubble_type_;
nit: request_type_

https://codereview.chromium.org/2123653006/diff/120001/chrome/browser/permiss...
File chrome/browser/permissions/permission_request.h (right):

https://codereview.chromium.org/2123653006/diff/120001/chrome/browser/permiss...
chrome/browser/permissions/permission_request.h:25: MULTIPLE,
One slight weirdness of making PermissionBubble*s become cross-platform is that
infobars don't currently coalesce. As a result some code paths (such as using
the MULTIPLE enum) are only reachable on desktop. But: my understanding is that
this CL is a precursor to implementing coalescing on Android, so this will in
fact become useful cross-platform once that launches, yeah?

https://codereview.chromium.org/2123653006/diff/120001/chrome/browser/permiss...
File chrome/browser/permissions/permission_request_impl.cc (right):

https://codereview.chromium.org/2123653006/diff/120001/chrome/browser/permiss...
chrome/browser/permissions/permission_request_impl.cc:62: #if defined(OS_MACOSX)
does this one also need the !defined(OS_ANDROID) guard?

[tsergeant, 2016-07-19 01:40:24]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[tsergeant, 2016-07-19 01:40:37]

https://codereview.chromium.org/2123653006/diff/120001/chrome/browser/permiss...
File chrome/browser/permissions/mock_permission_request.h (right):

https://codereview.chromium.org/2123653006/diff/120001/chrome/browser/permiss...
chrome/browser/permissions/mock_permission_request.h:44: PermissionRequestType
bubble_type);
On 2016/07/19 00:21:28, felt wrote:
> nit: request_type

Done.

https://codereview.chromium.org/2123653006/diff/120001/chrome/browser/permiss...
chrome/browser/permissions/mock_permission_request.h:48: PermissionRequestType
bubble_type_;
On 2016/07/19 00:21:28, felt wrote:
> nit: request_type_

Done.

https://codereview.chromium.org/2123653006/diff/120001/chrome/browser/permiss...
File chrome/browser/permissions/permission_request.h (right):

https://codereview.chromium.org/2123653006/diff/120001/chrome/browser/permiss...
chrome/browser/permissions/permission_request.h:25: MULTIPLE,
On 2016/07/19 00:21:28, felt wrote:
> One slight weirdness of making PermissionBubble*s become cross-platform is
that
> infobars don't currently coalesce. As a result some code paths (such as using
> the MULTIPLE enum) are only reachable on desktop. But: my understanding is
that
> this CL is a precursor to implementing coalescing on Android, so this will in
> fact become useful cross-platform once that launches, yeah?

Yup. There shouldn't be any point where PermissionRequest is used on Android
without coalesced requests in place.

https://codereview.chromium.org/2123653006/diff/120001/chrome/browser/permiss...
File chrome/browser/permissions/permission_request_impl.cc (right):

https://codereview.chromium.org/2123653006/diff/120001/chrome/browser/permiss...
chrome/browser/permissions/permission_request_impl.cc:62: #if defined(OS_MACOSX)
On 2016/07/19 00:21:28, felt wrote:
> does this one also need the !defined(OS_ANDROID) guard?

Done. It's not necessary for the file to compile (which is all it's doing on
Android now), but it'll be needed eventually.

[commit-bot: I haz the power, 2016-07-19 01:41:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 01:45:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 01:45:01]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[felt, 2016-07-19 01:45:35]

lgtm

[tsergeant, 2016-07-19 03:44:06]

Description was changed from

==========
Rename PermissionBubbleRequest to PermissionRequest

Additionally moves PermissionRequest from chrome/browser/ui/ to
chrome/browser/permissions. This is a step towards being able to share
generic permission request handling code between Bubbles on desktop and
InfoBars on Android.

This CL is a rebased and updated version of
https://codereview.chromium.org/1689513002/ by mlamouri@chromium.org

BUG=606138
==========

to

==========
Rename PermissionBubbleRequest to PermissionRequest

Additionally moves PermissionRequest from chrome/browser/ui/ to
chrome/browser/permissions and renames some helper/test classes. This is
a step towards being able to share generic permission request handling
code between Bubbles on desktop and InfoBars on Android.

This CL is a rebased and updated version of
https://codereview.chromium.org/1689513002/ by mlamouri@chromium.org

BUG=606138
==========

[tsergeant, 2016-07-19 03:58:26]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 03:58:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 04:08:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 04:08:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tsergeant, 2016-07-19 04:19:37]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 04:19:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-07-19 05:15:59]

tsergeant@chromium.org changed reviewers:
+ isherman@chromium.org, thestig@chromium.org

[tsergeant, 2016-07-19 05:16:00]

+isherman@ for histograms.xml

+thestig@ for everything else

PTAL thanks!

[commit-bot: I haz the power, 2016-07-19 05:16:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 05:16:27]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2016-07-19 06:41:27]

histograms.xml lgtm

[Lei Zhang, 2016-07-19 07:46:34]

lgtm

[tsergeant, 2016-07-19 23:40:36]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-07-19 23:40:37]

The patchset sent to the CQ was uploaded after l-g-t-m from felt@chromium.org
Link to the patchset: https://codereview.chromium.org/2123653006/#ps180001
(title: "Fix missed file")

[commit-bot: I haz the power, 2016-07-19 23:41:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 23:47:50]

Committed patchset #8 (id:180001)

[commit-bot: I haz the power, 2016-07-19 23:48:03]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 23:50:04]

Description was changed from

==========
Rename PermissionBubbleRequest to PermissionRequest

Additionally moves PermissionRequest from chrome/browser/ui/ to
chrome/browser/permissions and renames some helper/test classes. This is
a step towards being able to share generic permission request handling
code between Bubbles on desktop and InfoBars on Android.

This CL is a rebased and updated version of
https://codereview.chromium.org/1689513002/ by mlamouri@chromium.org

BUG=606138
==========

to

==========
Rename PermissionBubbleRequest to PermissionRequest

Additionally moves PermissionRequest from chrome/browser/ui/ to
chrome/browser/permissions and renames some helper/test classes. This is
a step towards being able to share generic permission request handling
code between Bubbles on desktop and InfoBars on Android.

This CL is a rebased and updated version of
https://codereview.chromium.org/1689513002/ by mlamouri@chromium.org

BUG=606138

Committed: https://crrev.com/58defcfb180432d2d1335f8b06766c2b4d746a3f
Cr-Commit-Position: refs/heads/master@{#406418}
==========

[commit-bot: I haz the power, 2016-07-19 23:50:06]

Patchset 8 (id:??) landed as
https://crrev.com/58defcfb180432d2d1335f8b06766c2b4d746a3f
Cr-Commit-Position: refs/heads/master@{#406418}