chrome/browser/download/download_permission_request.h - Issue 2123653006: Rename PermissionBubbleRequest to PermissionRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_permission_request.h

Issue 2123653006: Rename PermissionBubbleRequest to PermissionRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission_manager_rename

Patch Set: Fix missed file Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc ('k') | chrome/browser/download/download_permission_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_permission_request.h

diff --git a/chrome/browser/download/download_permission_request.h b/chrome/browser/download/download_permission_request.h

index a06c58139a72aa4523a7808e000c28ff1e94f28b..57da64045ac6d1d430031e970e610192d198cd7f 100644

--- a/chrome/browser/download/download_permission_request.h

+++ b/chrome/browser/download/download_permission_request.h

@@ -8,13 +8,13 @@

#include "base/macros.h"

#include "base/memory/weak_ptr.h"

#include "chrome/browser/download/download_request_limiter.h"

-#include "chrome/browser/ui/website_settings/permission_bubble_request.h"

+#include "chrome/browser/permissions/permission_request.h"

-// A permission bubble request that presents the user with a choice to allow

-// or deny multiple downloads from the same site. This confirmation step

-// protects against "carpet-bombing", where a malicious site forces multiple

-// downloads on an unsuspecting user.

-class DownloadPermissionRequest : public PermissionBubbleRequest {

+// A permission request that presents the user with a choice to allow or deny

+// multiple downloads from the same site. This confirmation step protects

+// against "carpet-bombing", where a malicious site forces multiple downloads on

+// an unsuspecting user.

+class DownloadPermissionRequest : public PermissionRequest {

public:

explicit DownloadPermissionRequest(

base::WeakPtr<DownloadRequestLimiter::TabDownloadState> host);

@@ -29,7 +29,7 @@ class DownloadPermissionRequest : public PermissionBubbleRequest {

void PermissionDenied() override;

void Cancelled() override;

void RequestFinished() override;

- PermissionBubbleType GetPermissionBubbleType() const override;

+ PermissionRequestType GetPermissionRequestType() const override;

base::WeakPtr<DownloadRequestLimiter::TabDownloadState> host_;

GURL request_origin_;