remoting/client/jni/jni_interface.cc - Issue 21236002: Chromoting Android app mouse/keyboard bugfixes and enhancements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/jni/jni_interface.cc

Issue 21236002: Chromoting Android app mouse/keyboard bugfixes and enhancements (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move non-negative and in-bounds input checks to C++, fix style nits Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/client/jni/jni_interface.cc

diff --git a/remoting/client/jni/jni_interface.cc b/remoting/client/jni/jni_interface.cc

index 5ca45a013cffc1e237051b18d912bf7e10d1daa8..088ac82a42f762c71c01038aaf8f78a518a8248e 100644

--- a/remoting/client/jni/jni_interface.cc

+++ b/remoting/client/jni/jni_interface.cc

@@ -120,6 +120,9 @@ JNIEXPORT void JNICALL JNI_IMPLEMENTATION(mouseActionNative)(

jint y,

jint which_button,

jboolean button_down) {

+ // Button must be within the bounds of the MouseEvent_MouseButton enum.

+ DCHECK(which_button >= 0 && which_button < 5);

remoting::ChromotingJniRuntime::GetInstance()->session()->PerformMouseAction(