remoting/client/jni/chromoting_jni_instance.cc - Issue 21236002: Chromoting Android app mouse/keyboard bugfixes and enhancements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/jni/chromoting_jni_instance.cc

Issue 21236002: Chromoting Android app mouse/keyboard bugfixes and enhancements (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move non-negative and in-bounds input checks to C++, fix style nits Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/client/jni/chromoting_jni_instance.cc

diff --git a/remoting/client/jni/chromoting_jni_instance.cc b/remoting/client/jni/chromoting_jni_instance.cc

index dcec68fcaadc559336627485d9fda1acba48ff18..764577c1c176066493283ba091dba5d7a1019afe 100644

--- a/remoting/client/jni/chromoting_jni_instance.cc

+++ b/remoting/client/jni/chromoting_jni_instance.cc

@@ -124,8 +124,9 @@ void ChromotingJniInstance::PerformKeyboardAction(int keyCode, bool keyDown) {

action.set_pressed(keyDown);

connection_->input_stub()->InjectKeyEvent(action);

}

- else

+ else {

LOG(WARNING) << "Ignoring unknown keycode: " << keyCode;

+ }

}

void ChromotingJniInstance::OnConnectionState(