Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: remoting/client/jni/android_keymap.h

Issue 21236002: Chromoting Android app mouse/keyboard bugfixes and enhancements (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move non-negative and in-bounds input checks to C++, fix style nits Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/jni/android_keymap.h
diff --git a/remoting/client/jni/android_keymap.h b/remoting/client/jni/android_keymap.h
index 9a9f3a3ff271b7d97abde8b3d1090885138cec84..c1de707ea4f778e562018336e378d51b83c49096 100644
--- a/remoting/client/jni/android_keymap.h
+++ b/remoting/client/jni/android_keymap.h
@@ -10,13 +10,13 @@
namespace remoting {
+// TODO(solb): crbug.com/265945
Sergey Ulanov 2013/07/30 21:46:00 Please keep the reference to the bug at the end. T
solb 2013/07/30 23:03:38 Done.
// This is a temporary hack to convert Android's virtual keycodes into USB
// scancodes. Unfortunately, the current solution uses key mappings whose
// layout is determined according to the client device's input locale instead
// of the host's internationalization preferences. The whole process needs to
// be rethought to accomplish this in an localizable and future-proof way.
-// TODO(solb): crbug.com/265945
-uint32 AndroidKeycodeToUsbKeycode(int android);
+uint32 AndroidKeycodeToUsbKeycode(size_t android);
} // namespace remoting

Powered by Google App Engine
This is Rietveld 408576698