remoting/client/jni/android_keymap.h - Issue 21236002: Chromoting Android app mouse/keyboard bugfixes and enhancements

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/client/jni/android_keymap.h

Issue 21236002: Chromoting Android app mouse/keyboard bugfixes and enhancements (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move non-negative and in-bounds input checks to C++, fix style nits Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java ('k') | remoting/client/jni/android_keymap.cc » ('j') | remoting/client/jni/android_keymap.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef REMOTING_CLIENT_JNI_ANDROID_KEYMAP_H_	5 #ifndef REMOTING_CLIENT_JNI_ANDROID_KEYMAP_H_

6 #define REMOTING_CLIENT_JNI_ANDROID_KEYMAP_H_	6 #define REMOTING_CLIENT_JNI_ANDROID_KEYMAP_H_

7	7

8 #include "base/basictypes.h"	8 #include "base/basictypes.h"

9 #include "base/memory/scoped_ptr.h"	9 #include "base/memory/scoped_ptr.h"

10	10

11 namespace remoting {	11 namespace remoting {

12	12

	13 // TODO(solb): crbug.com/265945
	Sergey Ulanov 2013/07/30 21:46:00 Please keep the reference to the bug at the end. T Please keep the reference to the bug at the end. That's the way comments like this are normally formatted, e.g.: // TODO(solb): Blah blah blah. // crbug.com/123123 solb 2013/07/30 23:03:38 Done. Show quoted text On 2013/07/30 21:46:00, Sergey Ulanov wrote: > Please keep the reference to the bug at the end. That's the way comments like > this are normally formatted, e.g.: > > // TODO(solb): Blah blah blah. > // crbug.com/123123 Done.
13 // This is a temporary hack to convert Android's virtual keycodes into USB	14 // This is a temporary hack to convert Android's virtual keycodes into USB

14 // scancodes. Unfortunately, the current solution uses key mappings whose	15 // scancodes. Unfortunately, the current solution uses key mappings whose

15 // layout is determined according to the client device's input locale instead	16 // layout is determined according to the client device's input locale instead

16 // of the host's internationalization preferences. The whole process needs to	17 // of the host's internationalization preferences. The whole process needs to

17 // be rethought to accomplish this in an localizable and future-proof way.	18 // be rethought to accomplish this in an localizable and future-proof way.

18 // TODO(solb): crbug.com/265945	19 uint32 AndroidKeycodeToUsbKeycode(size_t android);

19 uint32 AndroidKeycodeToUsbKeycode(int android);

20	20

21 } // namespace remoting	21 } // namespace remoting

22	22

23 #endif	23 #endif

OLD	NEW