Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 2123543002: Revert of Activate Complex text on Android after memory improvements (Closed)

Created:
4 years, 5 months ago by drott
Modified:
4 years, 5 months ago
Reviewers:
eae
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Activate Complex text on Android after memory improvements (patchset #1 id:1 of https://codereview.chromium.org/2120143002/ ) Reason for revert: Still shows comparable memory regressions. Original issue's description: > Activate Complex text on Android after memory improvements > > In the blocking bugs of crbug.com/617568 work was done on improving font > memory managament: Fixing the ref counting of the FontDataCache, zero > copy access to font blobs and purging the font cache on low memory > pressure. So it is time to give it another try and see whether this > addresses the memory regressions observed on bots when activating > complex text on Android seen in crbug.com/577306. > > TBR'ing to get bot results. We will revert again if the regression still > occurs. > > BUG=561099 > TBR=eae > > Committed: https://crrev.com/6867727d32a96418c1c34128251807ff712aff81 > Cr-Commit-Position: refs/heads/master@{#403648} TBR=eae@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=561099 Committed: https://crrev.com/f9da8aa04c5e8f134a50d10abdbea4d0ba645624 Cr-Commit-Position: refs/heads/master@{#403690}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/fonts/Font.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
drott
Created Revert of Activate Complex text on Android after memory improvements
4 years, 5 months ago (2016-07-04 16:00:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123543002/1
4 years, 5 months ago (2016-07-04 16:00:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-04 16:02:07 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-04 16:02:15 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f9da8aa04c5e8f134a50d10abdbea4d0ba645624 Cr-Commit-Position: refs/heads/master@{#403690}
4 years, 5 months ago (2016-07-04 16:03:55 UTC) #7
eae
4 years, 5 months ago (2016-07-05 22:08:23 UTC) #8
Message was sent while issue was closed.
LGTM post-facto. Sadness!

Powered by Google App Engine
This is Rietveld 408576698