Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(34)

Issue 2120143002: Activate Complex text on Android after memory improvements (Closed)

Created:
3 years, 9 months ago by drott
Modified:
3 years, 9 months ago
Reviewers:
eae
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Activate Complex text on Android after memory improvements In the blocking bugs of crbug.com/617568 work was done on improving font memory managament: Fixing the ref counting of the FontDataCache, zero copy access to font blobs and purging the font cache on low memory pressure. So it is time to give it another try and see whether this addresses the memory regressions observed on bots when activating complex text on Android seen in crbug.com/577306. TBR'ing to get bot results. We will revert again if the regression still occurs. BUG=561099 TBR=eae Committed: https://crrev.com/6867727d32a96418c1c34128251807ff712aff81 Cr-Commit-Position: refs/heads/master@{#403648}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/fonts/Font.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120143002/1
3 years, 9 months ago (2016-07-03 13:40:58 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/239480)
3 years, 9 months ago (2016-07-03 14:25:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120143002/1
3 years, 9 months ago (2016-07-04 07:24:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 9 months ago (2016-07-04 08:16:55 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
3 years, 9 months ago (2016-07-04 08:17:00 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6867727d32a96418c1c34128251807ff712aff81 Cr-Commit-Position: refs/heads/master@{#403648}
3 years, 9 months ago (2016-07-04 08:18:32 UTC) #10
drott
3 years, 9 months ago (2016-07-04 16:00:37 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2123543002/ by drott@chromium.org.

The reason for reverting is: Still shows comparable memory regressions..

Powered by Google App Engine
This is Rietveld 408576698