Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2123363002: ShellTest -> ServiceTest (Closed)

Created:
4 years, 5 months ago by Ben Goodger (Google)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, rjkroege, feature-media-reviews_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, dcheng, alokp+watch_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ShellTest -> ServiceTest TBR=rockot@chromium.org Committed: https://crrev.com/988bf0aacad131ccf1aeb68e1f2bd633bd90ca10 Cr-Commit-Position: refs/heads/master@{#404094}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -358 lines) Patch
M ash/mus/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/accelerator_registrar_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/mus/app_launch_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/mus/window_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/filesystem/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/files_test_base.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/filesystem/files_test_base.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M components/leveldb/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb/leveldb_service_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M components/leveldb/remote_iterator_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M media/mojo/services/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/media_mojo_unittest.cc View 7 chunks +19 lines, -18 lines 0 comments Download
M media/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/test/pipeline_integration_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M services/navigation/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/navigation/navigation_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M services/shell/public/cpp/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
A + services/shell/public/cpp/lib/service_test.cc View 4 chunks +15 lines, -14 lines 0 comments Download
D services/shell/public/cpp/lib/shell_test.cc View 1 chunk +0 lines, -81 lines 0 comments Download
A + services/shell/public/cpp/service_test.h View 6 chunks +18 lines, -18 lines 0 comments Download
D services/shell/public/cpp/shell_test.h View 1 chunk +0 lines, -112 lines 0 comments Download
M services/shell/tests/connect/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/connect/connect_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M services/shell/tests/lifecycle/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/lifecycle/lifecycle_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M services/shell/tests/shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/shell/shell_unittest.cc View 6 chunks +18 lines, -18 lines 0 comments Download
M services/shell/tests/shutdown/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/shutdown/shutdown_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/ui/clipboard/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/clipboard/clipboard_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M services/ui/public/cpp/tests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/public/cpp/tests/window_server_shelltest_base.h View 1 chunk +7 lines, -7 lines 0 comments Download
M services/ui/public/cpp/tests/window_server_shelltest_base.cc View 3 chunks +13 lines, -13 lines 0 comments Download
M services/ui/public/cpp/tests/window_server_test_base.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/public/cpp/tests/window_server_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/window_tree_client_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download

Dependent Patchsets:

Issue 2131493002 Patch 1
Issue 2131493002 Patch 20001

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123363002/20001
4 years, 5 months ago (2016-07-07 00:24:12 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/120899)
4 years, 5 months ago (2016-07-07 00:49:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123363002/40001
4 years, 5 months ago (2016-07-07 05:40:36 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-07 06:56:31 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 06:56:33 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 06:57:55 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/988bf0aacad131ccf1aeb68e1f2bd633bd90ca10
Cr-Commit-Position: refs/heads/master@{#404094}

Powered by Google App Engine
This is Rietveld 408576698