Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2131493002: ShellConnection -> ServiceContext (Closed)

Created:
4 years, 5 months ago by Ben Goodger (Google)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, rjkroege, feature-media-reviews_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, dcheng, alokp+watch_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@st
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ShellConnection -> ServiceContext TBR=rockot@chromium.org Committed: https://crrev.com/54ccd3cdd39f1b3752c66ed2fca1f3a1c4453ff9 Cr-Commit-Position: refs/heads/master@{#404333}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -579 lines) Patch
M chrome/app/mash/mash_runner.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/mash/mash_runner.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/base/mash_browser_tests_main.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/base/mojo_test_connector.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/base/mojo_test_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb/leveldb_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb/remote_iterator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 1 2 3 1 chunk +4 lines, -5 lines 0 comments Download
M content/common/mojo/embedded_application_runner.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/mojo_shell_connection.h View 2 chunks +4 lines, -4 lines 0 comments Download
M mash/example/common/mus_views_init.h View 3 chunks +4 lines, -4 lines 0 comments Download
M mash/example/window_type_launcher/main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_media_application.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/services/service_factory_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M media/mojo/services/service_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/catalog/catalog.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/catalog/catalog.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/navigation/navigation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M services/navigation/view_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M services/navigation/view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/background/background_shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/background/tests/background_shell_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/shell/public/cpp/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M services/shell/public/cpp/application_runner.h View 3 chunks +8 lines, -8 lines 0 comments Download
M services/shell/public/cpp/connection.h View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/public/cpp/connector.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/public/cpp/lib/application_runner.cc View 4 chunks +6 lines, -6 lines 0 comments Download
A + services/shell/public/cpp/lib/service_context.cc View 6 chunks +16 lines, -16 lines 0 comments Download
A + services/shell/public/cpp/lib/service_context_ref.cc View 5 chunks +18 lines, -18 lines 0 comments Download
M services/shell/public/cpp/lib/service_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D services/shell/public/cpp/lib/shell_connection.cc View 1 chunk +0 lines, -129 lines 0 comments Download
D services/shell/public/cpp/lib/shell_connection_ref.cc View 1 chunk +0 lines, -87 lines 0 comments Download
M services/shell/public/cpp/service.h View 1 chunk +1 line, -1 line 0 comments Download
A + services/shell/public/cpp/service_context.h View 4 chunks +23 lines, -22 lines 0 comments Download
A + services/shell/public/cpp/service_context_ref.h View 2 chunks +16 lines, -16 lines 0 comments Download
M services/shell/public/cpp/service_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
D services/shell/public/cpp/shell_connection.h View 1 chunk +0 lines, -106 lines 0 comments Download
D services/shell/public/cpp/shell_connection_ref.h View 1 chunk +0 lines, -59 lines 0 comments Download
M services/shell/runner/child/test_native_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/service_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/service_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/shell_public.gyp View 1 chunk +4 lines, -4 lines 0 comments Download
M services/shell/tests/lifecycle/app_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/tests/lifecycle/app_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/shell/tests/lifecycle/package.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M services/shell/tests/shell/shell_unittest.cc View 1 5 chunks +12 lines, -12 lines 0 comments Download
M services/ui/clipboard/clipboard_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/views_mus_test_suite.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131493002/20001
4 years, 5 months ago (2016-07-08 02:06:09 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/32994) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-08 02:09:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131493002/40001
4 years, 5 months ago (2016-07-08 02:17:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/92970) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-08 02:29:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131493002/60001
4 years, 5 months ago (2016-07-08 07:34:30 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-08 09:42:19 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 09:42:29 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 09:47:01 UTC) #14
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/54ccd3cdd39f1b3752c66ed2fca1f3a1c4453ff9
Cr-Commit-Position: refs/heads/master@{#404333}

Powered by Google App Engine
This is Rietveld 408576698