third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp - Issue 2123323004: Simplify OriginTrialContext and the way it validates tokens.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

Issue 2123323004: Simplify OriginTrialContext and the way it validates tokens. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: filter empty tokens in addTokens, and DCHECK in validateToken Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp ('K') | « third_party/WebKit/Source/core/origin_trials/testing/InternalsFrobulate.cpp ('k') | third_party/WebKit/public/platform/WebOriginTrialTokenStatus.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

diff --git a/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp b/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

index b1e85dfea8c7116da91adf1b9913152fb5d7395c..54927176ce029bc2d071643281b5e4bfa67c0b9e 100644

--- a/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

+++ b/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

@@ -99,7 +99,7 @@ void installOriginTrialsForTests(ScriptState* scriptState)

v8::Local<v8::Object> global = context->Global();

v8::Isolate* isolate = scriptState->isolate();

- if (!originTrialContext->featureBindingsInstalled("Frobulate") && originTrialContext->isFeatureEnabled("Frobulate", nullptr)) {

+ if (!originTrialContext->featureBindingsInstalled("Frobulate") && originTrialContext->isFeatureEnabled("Frobulate")) {

v8::Local<v8::String> internalsName = v8::String::NewFromOneByte(isolate, reinterpret_cast<const uint8_t*>("internals"), v8::NewStringType::kNormal).ToLocalChecked();

v8::Local<v8::Value> v8Internals = global->Get(context, internalsName).ToLocalChecked();

if (v8Internals->IsObject()) {