third_party/WebKit/Source/core/origin_trials/testing/InternalsFrobulate.cpp - Issue 2123323004: Simplify OriginTrialContext and the way it validates tokens.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/origin_trials/testing/InternalsFrobulate.cpp

Issue 2123323004: Simplify OriginTrialContext and the way it validates tokens. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: filter empty tokens in addTokens, and DCHECK in validateToken Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp ('K') | « third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp ('k') | third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/origin_trials/testing/InternalsFrobulate.cpp

diff --git a/third_party/WebKit/Source/core/origin_trials/testing/InternalsFrobulate.cpp b/third_party/WebKit/Source/core/origin_trials/testing/InternalsFrobulate.cpp

index aed634e711b7600d9b41135232fd6a5d9a02aa18..08c5c63d6909f961438680f39cc2a9afd8e2ab32 100644

--- a/third_party/WebKit/Source/core/origin_trials/testing/InternalsFrobulate.cpp

+++ b/third_party/WebKit/Source/core/origin_trials/testing/InternalsFrobulate.cpp

@@ -14,8 +14,8 @@ namespace blink {

bool InternalsFrobulate::frobulate(ScriptState* scriptState, Internals& internals, ExceptionState& exceptionState)

{

String errorMessage;

- if (!OriginTrials::originTrialsSampleAPIEnabled(scriptState->getExecutionContext(), errorMessage)) {

- exceptionState.throwDOMException(NotSupportedError, errorMessage);

+ if (!OriginTrials::originTrialsSampleAPIEnabled(scriptState->getExecutionContext())) {

+ exceptionState.throwDOMException(NotSupportedError, "The Origin Trials Sample API has not been enabled in this context");

return false;

}

return frobulateNoEnabledCheck(internals);