Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2123323002: Vulkan fixes for TesselatingPathRenderer test (Closed)

Created:
4 years, 5 months ago by jvanverth1
Modified:
4 years, 5 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Vulkan fixes for TesselatingPathRenderer test - Be sure to release all secondard command buffers on shutdown - Allow mapping of static buffers GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2123323002 Committed: https://skia.googlesource.com/skia/+/069c464a6bcac468ef543100828c83821286877f

Patch Set 1 #

Patch Set 2 : Fix void* delete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M src/gpu/vk/GrVkBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkBuffer.cpp View 1 1 chunk +16 lines, -12 lines 0 comments Download
M src/gpu/vk/GrVkResourceProvider.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/vk/GrVkUniformBuffer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
jvanverth1
4 years, 5 months ago (2016-07-06 19:20:15 UTC) #3
egdaniel
lgtm
4 years, 5 months ago (2016-07-06 19:36:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123323002/1
4 years, 5 months ago (2016-07-06 19:37:16 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 19:56:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/069c464a6bcac468ef543100828c83821286877f

Powered by Google App Engine
This is Rietveld 408576698