Issue 2123283002: Merge "arc: Fix custom notification crash on closing"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2123283002: Merge "arc: Fix custom notification crash on closing" (Closed)

Created:
4 years, 5 months ago by xiyuan

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

Merge "arc: Fix custom notification crash on closing" > Reset surface_ in ArcCustomNotificationView when the underlying > ArcCustomNotificationItem is gone or the notification surface is > removed. > > BUG=625220 > > Review-Url: https://codereview.chromium.org/2120593002 > Cr-Commit-Position: refs/heads/master@{#403796} > (cherry picked from commit 4f093ef33a9fc0d9661204fc0255b9b0d8dca995) Committed: https://chromium.googlesource.com/chromium/src/+/b7e631cde89ff25f738db2b4fbaf42e92b094b90

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -7 lines)			Patch
M	ui/arc/notification/arc_custom_notification_item.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/arc/notification/arc_custom_notification_item.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	ui/arc/notification/arc_custom_notification_view.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/arc/notification/arc_custom_notification_view.cc	View	4 chunks	+10 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

xiyuan

4 years, 5 months ago (2016-07-06 16:28:40 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b7e631cde89ff25f738db2b4fbaf42e92b094b90.