Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2120593002: arc: Fix custom notification crash on closing (Closed)

Created:
4 years, 5 months ago by xiyuan
Modified:
4 years, 5 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Fix custom notification crash on closing Reset surface_ in ArcCustomNotificationView when the underlying ArcCustomNotificationItem is gone or the notification surface is removed. BUG=625220 Committed: https://crrev.com/4f093ef33a9fc0d9661204fc0255b9b0d8dca995 Cr-Commit-Position: refs/heads/master@{#403796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M ui/arc/notification/arc_custom_notification_item.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_item.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_view.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/arc/notification/arc_custom_notification_view.cc View 4 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
xiyuan
4 years, 5 months ago (2016-07-01 19:28:11 UTC) #2
yoshiki
lgtm
4 years, 5 months ago (2016-07-05 03:38:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2120593002/1
4 years, 5 months ago (2016-07-05 16:13:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 16:50:27 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 16:50:31 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 16:52:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f093ef33a9fc0d9661204fc0255b9b0d8dca995
Cr-Commit-Position: refs/heads/master@{#403796}

Powered by Google App Engine
This is Rietveld 408576698