Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2123143002: Make it possible to create a v8::Function directly w/o a prototype (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make it possible to create a v8::Function directly w/o a prototype BUG=chromium:625823 R=verwaest@chromium.org Committed: https://crrev.com/46428e45e9982a7490685ff1af6ffe680096c1a4 Cr-Commit-Position: refs/heads/master@{#37549}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -19 lines) Patch
M include/v8.h View 1 3 chunks +7 lines, -5 lines 0 comments Download
M src/api.cc View 1 2 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jochen (gone - plz use gerrit)
4 years, 5 months ago (2016-07-06 09:12:11 UTC) #1
Toon Verwaest
lgtm with comment https://codereview.chromium.org/2123143002/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/2123143002/diff/1/include/v8.h#newcode3276 include/v8.h:3276: bool remove_constructor = false); Does it ...
4 years, 5 months ago (2016-07-06 10:56:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123143002/20001
4 years, 5 months ago (2016-07-06 11:21:53 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-06 11:41:47 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 11:42:14 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/46428e45e9982a7490685ff1af6ffe680096c1a4
Cr-Commit-Position: refs/heads/master@{#37549}

Powered by Google App Engine
This is Rietveld 408576698