Remove URLRequest::Delegate::OnBeforeNetworkStart.

net/http/http_network_transaction_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_network_transaction.h"
 
 #include <math.h>  // ceil
 #include <stdarg.h>
 #include <stdint.h>
 
@@ skipping 1635 matching lines @@
   MockRead data_reads[] = {
     MockRead(SYNCHRONOUS, OK),  // EOF
     MockRead("HTTP/1.0 200 OK\r\n\r\n"),  // Should not be used
     MockRead("hello world"),
     MockRead(SYNCHRONOUS, OK),
   };
   SimpleGetHelperResult out = SimpleGetHelper(data_reads,
                                               arraysize(data_reads));
   EXPECT_THAT(out.rv, IsError(ERR_EMPTY_RESPONSE));
 }
-//
-//// Test that network access can be deferred and resumed.
-// TEST_P(HttpNetworkTransactionTest, ThrottleBeforeNetworkStart) {
-//  HttpRequestInfo request;
-//  request.method = "GET";
-//  request.url = GURL("http://www.example.org/");
-//  request.load_flags = 0;
-//
-//  std::unique_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
-//  std::unique_ptr<HttpTransaction> trans(
-//      new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
-//
-//  // Defer on OnBeforeNetworkStart.
-//  BeforeNetworkStartHandler net_start_handler(true);  // defer
-//  trans->SetBeforeNetworkStartCallback(
-//      base::Bind(&BeforeNetworkStartHandler::OnBeforeNetworkStart,
-//                 base::Unretained(&net_start_handler)));
-//
-//  MockRead data_reads[] = {
-//    MockRead("HTTP/1.0 200 OK\r\n"),
-//    MockRead("Content-Length: 5\r\n\r\n"),
-//    MockRead("hello"),
-//    MockRead(SYNCHRONOUS, 0),
-//  };
-//  StaticSocketDataProvider data(data_reads, arraysize(data_reads), NULL, 0);
-//  session_deps_.socket_factory->AddSocketDataProvider(&data);
-//
-//  TestCompletionCallback callback;
-//
-//  int rv = trans->Start(&request, callback.callback(), BoundNetLog());
-//  EXPECT_THAT(rv, IsError(ERR_IO_PENDING));
-//  base::RunLoop().RunUntilIdle();
-//
-//  // Should have deferred for network start.
-//  EXPECT_TRUE(net_start_handler.observed_before_network_start());
-//  EXPECT_EQ(LOAD_STATE_WAITING_FOR_DELEGATE, trans->GetLoadState());
-//
-//  trans->ResumeNetworkStart();
-//  rv = callback.WaitForResult();
-//  EXPECT_THAT(rv, IsOk());
-//  EXPECT_TRUE(trans->GetResponseInfo());
-//
-//  scoped_refptr<IOBufferWithSize> io_buf(new IOBufferWithSize(100));
-//  rv = trans->Read(io_buf.get(), io_buf->size(), callback.callback());
-//  if (rv == ERR_IO_PENDING)
-//    rv = callback.WaitForResult();
-//  EXPECT_EQ(5, rv);
-//  trans.reset();
-//}
-//
-//// Test that network use can be deferred and canceled.
-// TEST_P(HttpNetworkTransactionTest, ThrottleAndCancelBeforeNetworkStart) {
-//  HttpRequestInfo request;
-//  request.method = "GET";
-//  request.url = GURL("http://www.example.org/");
-//  request.load_flags = 0;
-//
-//  std::unique_ptr<HttpNetworkSession> session(CreateSession(&session_deps_));
-//  std::unique_ptr<HttpTransaction> trans(
-//      new HttpNetworkTransaction(DEFAULT_PRIORITY, session.get()));
-//
-//  // Defer on OnBeforeNetworkStart.
-//  BeforeNetworkStartHandler net_start_handler(true);  // defer
-//  trans->SetBeforeNetworkStartCallback(
-//      base::Bind(&BeforeNetworkStartHandler::OnBeforeNetworkStart,
-//                 base::Unretained(&net_start_handler)));
-//
-//  TestCompletionCallback callback;
-//
-//  int rv = trans->Start(&request, callback.callback(), BoundNetLog());
-//  EXPECT_THAT(rv, IsError(ERR_IO_PENDING));
-//  base::RunLoop().RunUntilIdle();
-//
-//  // Should have deferred for network start.
-//  EXPECT_TRUE(net_start_handler.observed_before_network_start());
-//  EXPECT_EQ(LOAD_STATE_WAITING_FOR_DELEGATE, trans->GetLoadState());
-//}
 
 // Next 2 cases (KeepAliveEarlyClose and KeepAliveEarlyClose2) are regression
 // tests. There was a bug causing HttpNetworkTransaction to hang in the
 // destructor in such situations.
 // See http://crbug.com/154712 and http://crbug.com/156609.
 TEST_P(HttpNetworkTransactionTest, KeepAliveEarlyClose) {
   HttpRequestInfo request;
   request.method = "GET";
   request.url = GURL("http://www.example.org/");
   request.load_flags = 0;
@@ skipping 14078 matching lines @@
   base::RunLoop().RunUntilIdle();
 
   EXPECT_TRUE(trans.GetResponseInfo()->was_fetched_via_spdy);
   HttpRequestHeaders headers;
   ASSERT_TRUE(trans.GetFullRequestHeaders(&headers));
   EXPECT_TRUE(headers.HasHeader(HttpRequestHeaders::kTokenBinding));
 }
 #endif  // !defined(OS_IOS)
 
 }  // namespace net