Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4255)

Unified Diff: blimp/engine/app/blimp_engine_crash_keys.cc

Issue 2123073002: Switch chrome_elf exception handling from breakpad to crashpad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update crash keys and add comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/chrome_crash_reporter_client_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/app/blimp_engine_crash_keys.cc
diff --git a/blimp/engine/app/blimp_engine_crash_keys.cc b/blimp/engine/app/blimp_engine_crash_keys.cc
index d858f50286808d84d5e46b60c9968601bf86ffe8..ae41595ab12f183434dd785e24586b9ad5c1329d 100644
--- a/blimp/engine/app/blimp_engine_crash_keys.cc
+++ b/blimp/engine/app/blimp_engine_crash_keys.cc
@@ -13,7 +13,9 @@ namespace engine {
size_t RegisterEngineCrashKeys() {
// For now these need to be kept relatively up to date with those in
- // //chrome/common/crash_keys.cc::RegisterChromeCrashKeys()
+ // 1. //chrome/common/crash_keys.cc::RegisterChromeCrashKeys()
+ // 2. //chrome/app/chrome_crash_reporter_client_win.cc::
+ // RegisterCrashKeysHelper()
Wez 2016/07/06 19:36:50 We don't build the Blimp Engine for Windows, so I
ananta 2016/07/07 12:43:20 Yes. While we don't build Blimp for Windows, the c
Wez 2016/07/08 22:54:09 If they're "mostly common" then isn't staying up-t
ananta 2016/07/09 14:09:32 Fair enough. Reverted the changes to the blimp_eng
// All of the keys used in //content and //components/crash must show up
// here.
// TODO(marcinjb): Change the approach when http://crbug.com/598854 is
« no previous file with comments | « no previous file | chrome/app/chrome_crash_reporter_client_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698