Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2123063003: V8: Remove gyp-flag-comparison feature after MB switch. (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, vogelheim, jochen (gone - plz use gerrit)
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

V8: Remove gyp-flag-comparison feature after MB switch. The feature allowed us to compare infra-side with v8-side gyp flags once for all bots after the MB switch. It is now obsolete. BUG=616035 Committed: https://chromium.googlesource.com/chromium/tools/build/+/7e2069ad4011c6f8ca6989ea43e80c6921142385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -1524 lines) Patch
M scripts/slave/recipe_modules/v8/api.py View 5 chunks +16 lines, -78 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN.json View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN___debug_builder.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN_arm64___debug_builder.json View 1 chunk +1 line, -14 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN_no_inline___release_builder.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_TSAN.json View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json View 1 chunk +1 line, -8 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___cfi.json View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug_builder.json View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___gcov_coverage.json View 1 chunk +1 line, -9 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot.json View 1 chunk +1 line, -9 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_empty_json.json View 1 chunk +1 line, -9 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_one_failure.json View 1 chunk +1 line, -9 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures.json View 3 chunks +3 lines, -27 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_flakes.json View 1 chunk +1 line, -9 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_wrong_results.json View 1 chunk +1 line, -9 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux_ASAN_arm___debug_builder.json View 1 chunk +1 line, -16 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux_ASAN_mipsel___debug_builder.json View 1 chunk +1 line, -16 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___arm64___sim___MSAN.json View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json View 1 chunk +1 line, -12 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug_builder.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___full_debug.json View 1 chunk +1 line, -12 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___interpreted_regexp.json View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___noi18n___debug.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_builder.json View 1 chunk +1 line, -12 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_debug_builder.json View 1 chunk +1 line, -14 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable.json View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect.json View 4 chunks +4 lines, -44 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_one_change.json View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_override_changes.json View 4 chunks +4 lines, -44 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_recurring_failure.json View 2 chunks +2 lines, -22 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_tests_too_long.json View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared_bisect_swarming.json View 4 chunks +4 lines, -52 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___swarming_staging.json View 1 chunk +1 line, -8 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___vtunejit.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux_gcc_4_8.json View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac.json View 1 chunk +1 line, -12 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64.json View 1 chunk +1 line, -9 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64_ASAN.json View 1 chunk +1 line, -12 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64___debug.json View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac_GC_Stress.json View 1 chunk +1 line, -14 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac___debug.json View 1 chunk +1 line, -14 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Random_Deopt_Fuzzer___debug.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___builder.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug_builder.json View 1 chunk +1 line, -15 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___nosnap___shared.json View 1 chunk +1 line, -15 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64.json View 1 chunk +1 line, -10 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___clang.json View 1 chunk +1 line, -8 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___debug.json View 1 chunk +1 line, -12 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Android_Arm64___builder.json View 1 chunk +1 line, -12 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Android_Arm___builder.json View 1 chunk +1 line, -12 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Arm___builder.json View 1 chunk +1 line, -12 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Arm___debug_builder.json View 1 chunk +1 line, -14 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim.json View 1 chunk +1 line, -9 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___debug.json View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___gc_stress.json View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___nosnap___debug.json View 1 chunk +1 line, -12 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm___sim.json View 1 chunk +1 line, -12 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm___sim___debug.json View 1 chunk +1 line, -14 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mips64el___sim___builder.json View 1 chunk +1 line, -8 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim___builder.json View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___ppc64___sim.json View 1 chunk +1 line, -8 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___ppc___sim.json View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___s390___sim.json View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___s390x___sim.json View 1 chunk +1 line, -8 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___x87___nosnap___debug_builder.json View 1 chunk +1 line, -15 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_android_arm_compile_rel.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_asan_rel_ng.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_dbg.json View 1 chunk +1 line, -12 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_rel_ng.json View 1 chunk +1 line, -10 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_msan_rel.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json View 1 chunk +1 line, -10 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_sanitizer_coverage_rel.json View 1 chunk +1 line, -15 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_tsan_rel.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_dbg.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_gc_stress_dbg.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_rel_ng.json View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_dbg.json View 1 chunk +1 line, -16 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_rel.json View 1 chunk +1 line, -14 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_rel_positional_extra_flags.json View 1 chunk +1 line, -14 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_dbg.json View 1 chunk +1 line, -16 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_rel_ng.json View 1 chunk +1 line, -14 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_avx2_dbg.json View 1 chunk +1 line, -15 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_dbg_ng.json View 1 chunk +1 line, -15 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gc_stress_dbg.json View 1 chunk +1 line, -15 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gcc_compile_rel.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gcc_rel.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_mips64el_compile_rel.json View 1 chunk +1 line, -10 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_mipsel_compile_rel.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nodcheck_rel_ng.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_noi18n_rel_ng.json View 1 chunk +1 line, -14 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nosnap_dbg.json View 1 chunk +1 line, -16 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nosnap_rel.json View 1 chunk +1 line, -14 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng.json View 1 chunk +1 line, -14 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_asan_rel.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_dbg.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_rel.json View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_dbg.json View 1 chunk +1 line, -16 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_gc_stress_dbg.json View 1 chunk +1 line, -16 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_rel_ng.json View 1 chunk +1 line, -14 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_dbg.json View 1 chunk +1 line, -13 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng.json View 1 chunk +1 line, -11 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_compile_dbg.json View 1 chunk +1 line, -15 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_dbg.json View 1 chunk +1 line, -16 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_nosnap_shared_rel_ng.json View 1 chunk +1 line, -16 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_rel_ng.json View 1 chunk +1 line, -14 lines 0 comments Download

Dependent Patchsets:

Issue 2119363003 Patch 1

Messages

Total messages: 10 (6 generated)
Michael Achenbach
PTAL
4 years, 5 months ago (2016-07-06 12:51:33 UTC) #5
tandrii(chromium)
lgtm
4 years, 5 months ago (2016-07-06 14:12:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123063003/1
4 years, 5 months ago (2016-07-06 14:14:43 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 14:19:01 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/7e2069ad4011c6f8ca69...

Powered by Google App Engine
This is Rietveld 408576698