Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2119363003: V8: Add temporary bots to support gyp (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, jochen (gone - plz use gerrit), vogelheim
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -42 lines) Patch
M masters/master.client.v8/master.cfg View 3 chunks +10 lines, -0 lines 0 comments Download
M masters/master.client.v8/slaves.cfg View 1 chunk +2 lines, -1 line 0 comments Download
M masters/master.tryserver.v8/master.cfg View 2 chunks +7 lines, -0 lines 0 comments Download
M masters/master.tryserver.v8/slaves.cfg View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/v8/builders.py View 2 chunks +40 lines, -0 lines 1 comment Download
A + scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___gyp.json View 8 chunks +9 lines, -9 lines 0 comments Download
A + scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_gyp_rel_ng.json View 7 chunks +9 lines, -12 lines 0 comments Download
A + scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_gyp_rel_ng_triggered.json View 4 chunks +25 lines, -20 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/2119363003/diff/1/scripts/slave/recipe_modules/v8/builders.py File scripts/slave/recipe_modules/v8/builders.py (right): https://codereview.chromium.org/2119363003/diff/1/scripts/slave/recipe_modules/v8/builders.py#newcode1808 scripts/slave/recipe_modules/v8/builders.py:1808: 'chromium_apply_config': ['no_dcheck'], No dchecks as we only have ...
4 years, 5 months ago (2016-07-06 09:58:30 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119363003/1
4 years, 5 months ago (2016-07-06 09:58:44 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-06 10:02:48 UTC) #7
tandrii(chromium)
lgtm
4 years, 5 months ago (2016-07-06 10:22:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119363003/1
4 years, 5 months ago (2016-07-06 14:36:22 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 14:39:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/6cd6eedf865126865cd6...

Powered by Google App Engine
This is Rietveld 408576698