third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp - Issue 2123053002: Improve scroll anchoring's interactions with the visual viewport

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp

Issue 2123053002: Improve scroll anchoring's interactions with the visual viewport (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix broken tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp ('k') | third_party/WebKit/Source/platform/scroll/ScrollableArea.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp

index 1a8fb974ba18712e52eb7276db458f7797a3324b..c3436cef2669b7828cf2923cf10f3649af17856f 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp

@@ -627,9 +627,8 @@ TEST(ScrollAnimatorTest, MainThreadAnimationTargetAdjustment)

EXPECT_GT(pos.y(), 0);

// Adjustment

- IntSize adjustment = IntSize(10, -10);

- animator->adjustAnimationAndSetScrollPosition(adjustment, AnchoringScroll);

- EXPECT_EQ(pos + FloatSize(adjustment), animator->currentPosition());

+ FloatPoint newPos = pos + FloatSize(10, -10);

+ animator->adjustAnimationAndSetScrollPosition(newPos, AnchoringScroll);

EXPECT_EQ(FloatPoint(110, 90), animator->desiredTargetPosition());

// Animation finished