Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp

Issue 2123053002: Improve scroll anchoring's interactions with the visual viewport (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix broken tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp
diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp
index 9c7c007b7642c9c39160f248edfb47a716d5e347..b01312567222d8fa61d42b09b5d8a00715454677 100644
--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp
+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp
@@ -293,11 +293,18 @@ void ScrollAnimatorCompositorCoordinator::updateCompositorAnimations()
updateImplOnlyCompositorAnimations();
}
+void ScrollAnimatorCompositorCoordinator::scrollPositionChanged(
+ const DoublePoint& offset, ScrollType scrollType)
+{
+ getScrollableArea()->scrollPositionChanged(offset, scrollType);
+}
+
void ScrollAnimatorCompositorCoordinator::adjustAnimationAndSetScrollPosition(
- IntSize adjustment, ScrollType scrollType) {
+ const DoublePoint& position, ScrollType scrollType)
+{
// Subclasses should override this and adjust the animation as necessary.
- getScrollableArea()->setScrollPosition(
- getScrollableArea()->scrollPositionDouble() + adjustment, scrollType);
+ DoublePoint adjustedPos = getScrollableArea()->clampScrollPosition(position);
+ scrollPositionChanged(adjustedPos, scrollType);
}
void ScrollAnimatorCompositorCoordinator::adjustImplOnlyScrollOffsetAnimation(

Powered by Google App Engine
This is Rietveld 408576698